Skip to content

Commit 88e4124

Browse files
adamgellclaude
andcommitted
ci(codesign): read signing identifiers from environment variables
Move AZURE_TENANT_ID, AZURE_CLIENT_ID, SIGNING_ENDPOINT, SIGNING_ACCOUNT_NAME, and SIGNING_PROFILE_NAME from environment secrets to environment *variables* in the codesigning environment. These are non-secret identifiers, so keeping them as verifiable variables removes them as a source of 403 signing failures. Only AZURE_CLIENT_SECRET and SYNCFUSION_LICENSE_KEY remain secrets. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 591c1fc commit 88e4124

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

.github/workflows/cmprojectx-codesign.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -140,12 +140,14 @@ jobs:
140140
# the MSI + MSIX (see packaging/installer.mpdev.json). SYNCFUSION_LICENSE_KEY licenses the
141141
# CA->PPTX export (mpdev bakes it into the installer's env var); empty => trial watermark.
142142
SYNCFUSION_LICENSE_KEY: ${{ secrets.SYNCFUSION_LICENSE_KEY }}
143-
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
144-
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
143+
# Non-secret signing identifiers as environment VARIABLES (verifiable). Only the client
144+
# secret is a real credential. All live in the `codesigning` environment.
145+
AZURE_TENANT_ID: ${{ vars.AZURE_TENANT_ID }}
146+
AZURE_CLIENT_ID: ${{ vars.AZURE_CLIENT_ID }}
145147
AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
146-
SIGNING_ENDPOINT: ${{ secrets.SIGNING_ENDPOINT }}
147-
SIGNING_ACCOUNT_NAME: ${{ secrets.SIGNING_ACCOUNT_NAME }}
148-
SIGNING_PROFILE_NAME: ${{ secrets.SIGNING_PROFILE_NAME }}
148+
SIGNING_ENDPOINT: ${{ vars.SIGNING_ENDPOINT }}
149+
SIGNING_ACCOUNT_NAME: ${{ vars.SIGNING_ACCOUNT_NAME }}
150+
SIGNING_PROFILE_NAME: ${{ vars.SIGNING_PROFILE_NAME }}
149151
steps:
150152
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
151153
with:

0 commit comments

Comments
 (0)