feat(ocl): implement an event system for evaluation#356
Open
tachyonicClock wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
tachyonicClock
force-pushed
the
events
branch
3 times, most recently
from
c7278b4 to
dffed48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An event/hook/plugin system similar (but more dynamic) to PyTorch lightning's Callback class or Avalanche's plugins. I needed a way to get the predictions of a learner from a replay buffer without having to modify the replay buffers owner. With the new system the replay buffer subscribes to
TrainBatchPredict. Another use-case is when we have nested learnersOuterLearner(InnerLearner)and the inner learner needs to know about tasksTestTaskBegin. At the moment we need to proxy the signals.on_train_taskfunction calls throughOuterLearnerto theInnerLearner. With the new system we subscribe the inner learner first and then pass it into the outer learner. The system will also allow for custom evaluators and loggers.A big chunk of the changes is spitting up the evaluation module into smaller files