Skip to content

Commit 4d667ad

Browse files
[flags] Clean up enableHiddenSubtreeInsertionEffectCleanup (facebook#35918)
Been enabled in stable for quite a while, also rolled out at Meta. DiffTrain build for [e0cc720](facebook@e0cc720)
1 parent 9008f16 commit 4d667ad

37 files changed

Lines changed: 7469 additions & 10080 deletions

compiled/eslint-plugin-react-hooks/index.js

Lines changed: 4408 additions & 7218 deletions
Large diffs are not rendered by default.

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
38cd020c1fb8a1e88b7852160796f411926a6fac
1+
e0cc7202e14418b453c69c4f06dc00c64151f202
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
38cd020c1fb8a1e88b7852160796f411926a6fac
1+
e0cc7202e14418b453c69c4f06dc00c64151f202

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1482,7 +1482,7 @@ __DEV__ &&
14821482
exports.useTransition = function () {
14831483
return resolveDispatcher().useTransition();
14841484
};
1485-
exports.version = "19.3.0-www-classic-38cd020c-20260219";
1485+
exports.version = "19.3.0-www-classic-e0cc7202-20260227";
14861486
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14871487
"function" ===
14881488
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1482,7 +1482,7 @@ __DEV__ &&
14821482
exports.useTransition = function () {
14831483
return resolveDispatcher().useTransition();
14841484
};
1485-
exports.version = "19.3.0-www-modern-38cd020c-20260219";
1485+
exports.version = "19.3.0-www-modern-e0cc7202-20260227";
14861486
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14871487
"function" ===
14881488
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,4 +610,4 @@ exports.useSyncExternalStore = function (
610610
exports.useTransition = function () {
611611
return ReactSharedInternals.H.useTransition();
612612
};
613-
exports.version = "19.3.0-www-classic-38cd020c-20260219";
613+
exports.version = "19.3.0-www-classic-e0cc7202-20260227";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,4 +610,4 @@ exports.useSyncExternalStore = function (
610610
exports.useTransition = function () {
611611
return ReactSharedInternals.H.useTransition();
612612
};
613-
exports.version = "19.3.0-www-modern-38cd020c-20260219";
613+
exports.version = "19.3.0-www-modern-e0cc7202-20260227";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ exports.useSyncExternalStore = function (
614614
exports.useTransition = function () {
615615
return ReactSharedInternals.H.useTransition();
616616
};
617-
exports.version = "19.3.0-www-classic-38cd020c-20260219";
617+
exports.version = "19.3.0-www-classic-e0cc7202-20260227";
618618
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
619619
"function" ===
620620
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ exports.useSyncExternalStore = function (
614614
exports.useTransition = function () {
615615
return ReactSharedInternals.H.useTransition();
616616
};
617-
exports.version = "19.3.0-www-modern-38cd020c-20260219";
617+
exports.version = "19.3.0-www-modern-e0cc7202-20260227";
618618
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
619619
"function" ===
620620
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 38 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -3044,7 +3044,20 @@ __DEV__ &&
30443044
workInProgress
30453045
);
30463046
nextFiber = null;
3047-
} else nextFiber = fiber.child;
3047+
} else
3048+
13 === fiber.tag &&
3049+
null !== fiber.memoizedState &&
3050+
null === fiber.memoizedState.dehydrated
3051+
? ((fiber.lanes |= renderLanes),
3052+
(nextFiber = fiber.alternate),
3053+
null !== nextFiber && (nextFiber.lanes |= renderLanes),
3054+
scheduleContextWorkOnParentPath(
3055+
fiber.return,
3056+
renderLanes,
3057+
workInProgress
3058+
),
3059+
(nextFiber = forcePropagateEntireTree ? fiber.child : null))
3060+
: (nextFiber = fiber.child);
30483061
if (null !== nextFiber) nextFiber.return = fiber;
30493062
else
30503063
for (nextFiber = fiber; null !== nextFiber; ) {
@@ -3110,6 +3123,7 @@ __DEV__ &&
31103123
forcePropagateEntireTree
31113124
);
31123125
workInProgress.flags |= 262144;
3126+
return null !== current;
31133127
}
31143128
function checkIfContextChanged(currentDependencies) {
31153129
for (
@@ -9406,7 +9420,14 @@ __DEV__ &&
94069420
(workInProgress.flags |= 128),
94079421
null
94089422
);
9409-
if (0 !== (renderLanes & workInProgress.child.childLanes))
9423+
stateNode = propagateParentContextChanges(
9424+
current,
9425+
workInProgress,
9426+
renderLanes,
9427+
!1
9428+
);
9429+
var primaryChildLanes = workInProgress.child.childLanes;
9430+
if (stateNode || 0 !== (renderLanes & primaryChildLanes))
94109431
return updateSuspenseComponent(
94119432
current,
94129433
workInProgress,
@@ -9429,7 +9450,7 @@ __DEV__ &&
94299450
workInProgress,
94309451
renderLanes
94319452
);
9432-
var didSuspendBefore = 0 !== (current.flags & 128);
9453+
primaryChildLanes = 0 !== (current.flags & 128);
94339454
stateNode = 0 !== (renderLanes & workInProgress.childLanes);
94349455
stateNode ||
94359456
(propagateParentContextChanges(
@@ -9439,7 +9460,7 @@ __DEV__ &&
94399460
!1
94409461
),
94419462
(stateNode = 0 !== (renderLanes & workInProgress.childLanes)));
9442-
if (didSuspendBefore) {
9463+
if (primaryChildLanes) {
94439464
if (stateNode)
94449465
return updateSuspenseListComponent(
94459466
current,
@@ -9448,11 +9469,11 @@ __DEV__ &&
94489469
);
94499470
workInProgress.flags |= 128;
94509471
}
9451-
didSuspendBefore = workInProgress.memoizedState;
9452-
null !== didSuspendBefore &&
9453-
((didSuspendBefore.rendering = null),
9454-
(didSuspendBefore.tail = null),
9455-
(didSuspendBefore.lastEffect = null));
9472+
primaryChildLanes = workInProgress.memoizedState;
9473+
null !== primaryChildLanes &&
9474+
((primaryChildLanes.rendering = null),
9475+
(primaryChildLanes.tail = null),
9476+
(primaryChildLanes.lastEffect = null));
94569477
pushSuspenseListContext(workInProgress, suspenseStackCursor.current);
94579478
if (stateNode) break;
94589479
else return null;
@@ -12777,13 +12798,11 @@ __DEV__ &&
1277712798
case 11:
1277812799
case 14:
1277912800
case 15:
12780-
(!enableHiddenSubtreeInsertionEffectCleanup &&
12781-
offscreenSubtreeWasHidden) ||
12782-
commitHookEffectListUnmount(
12783-
Insertion,
12784-
deletedFiber,
12785-
nearestMountedAncestor
12786-
);
12801+
commitHookEffectListUnmount(
12802+
Insertion,
12803+
deletedFiber,
12804+
nearestMountedAncestor
12805+
);
1278712806
offscreenSubtreeWasHidden ||
1278812807
commitHookLayoutUnmountEffects(
1278912808
deletedFiber,
@@ -18137,8 +18156,6 @@ __DEV__ &&
1813718156
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
1813818157
enableEffectEventMutationPhase =
1813918158
dynamicFeatureFlags.enableEffectEventMutationPhase,
18140-
enableHiddenSubtreeInsertionEffectCleanup =
18141-
dynamicFeatureFlags.enableHiddenSubtreeInsertionEffectCleanup,
1814218159
enableInfiniteRenderLoopDetection =
1814318160
dynamicFeatureFlags.enableInfiniteRenderLoopDetection,
1814418161
enableNoCloningMemoCache = dynamicFeatureFlags.enableNoCloningMemoCache,
@@ -20383,10 +20400,10 @@ __DEV__ &&
2038320400
(function () {
2038420401
var internals = {
2038520402
bundleType: 1,
20386-
version: "19.3.0-www-classic-38cd020c-20260219",
20403+
version: "19.3.0-www-classic-e0cc7202-20260227",
2038720404
rendererPackageName: "react-art",
2038820405
currentDispatcherRef: ReactSharedInternals,
20389-
reconcilerVersion: "19.3.0-www-classic-38cd020c-20260219"
20406+
reconcilerVersion: "19.3.0-www-classic-e0cc7202-20260227"
2039020407
};
2039120408
internals.overrideHookState = overrideHookState;
2039220409
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -20421,7 +20438,7 @@ __DEV__ &&
2042120438
exports.Shape = Shape;
2042220439
exports.Surface = Surface;
2042320440
exports.Text = Text;
20424-
exports.version = "19.3.0-www-classic-38cd020c-20260219";
20441+
exports.version = "19.3.0-www-classic-e0cc7202-20260227";
2042520442
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2042620443
"function" ===
2042720444
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)