Skip to content

Commit ee03ebc

Browse files
committed
Improve percent escaping test assertion
Change assertion to explicitly verify documentation string with % characters appears in help output, confirming percent escaping works properly. Also use 'string' type instead of 'integer' for better semantic clarity.
1 parent 6d3db1a commit ee03ebc

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

tests/unit/test_argprocess.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -894,6 +894,7 @@ def test_json_value_decode_error(self):
894894
with self.assertRaises(ParamError):
895895
unpack_cli_arg(self.p, value)
896896

897+
897898
class TestArgumentPercentEscaping(BaseArgProcessTest):
898899
def _test_percent_escaping(self, arg_type, arg_class, doc_string):
899900
argument = self.create_argument(
@@ -914,16 +915,16 @@ def _test_percent_escaping(self, arg_type, arg_class, doc_string):
914915
arg_table = {arg.name: arg}
915916
parser = ArgTableArgParser(arg_table)
916917
help_output = parser.format_help()
917-
self.assertIn(arg.cli_name, help_output)
918+
self.assertIn(doc_string, help_output)
918919

919920
def test_cli_argument_escapes_percent(self):
920-
self._test_percent_escaping('integer', CLIArgument, 'Symbols: % ^ & *')
921+
self._test_percent_escaping('string', CLIArgument, 'Symbols: % ^ & *')
921922

922923
def test_boolean_argument_escapes_percent(self):
923924
self._test_percent_escaping('boolean', BooleanArgument, 'Symbols: % ^ & *')
924925

925926
def test_cli_argument_escapes_url_encoded_percent(self):
926-
self._test_percent_escaping('integer', CLIArgument, 'File: test%28file%29.png')
927+
self._test_percent_escaping('string', CLIArgument, 'File: test%28file%29.png')
927928

928929
def test_boolean_argument_escapes_url_encoded_percent(self):
929930
self._test_percent_escaping('boolean', BooleanArgument, 'File: test%28file%29.png')

0 commit comments

Comments
 (0)