feat(streaming): emit ReasoningDeltaEvent for reasoning/thinking deltas (#825)

.agents/skills/code-change-verification/SKILL.md

@@ -14,22 +14,25 @@ Ensure work is only marked complete after formatting, linting, type checking, an
 1. Keep this skill at `./.agents/skills/code-change-verification` so it loads automatically for the repository.
 2. macOS/Linux: `bash .agents/skills/code-change-verification/scripts/run.sh`.
 3. Windows: `powershell -ExecutionPolicy Bypass -File .agents/skills/code-change-verification/scripts/run.ps1`.
-4. If any command fails, fix the issue, rerun the script, and report the failing output.
-5. Confirm completion only when all commands succeed with no remaining issues.
+4. The scripts run `make format` first, then run `make lint`, `make typecheck`, and `make tests` in parallel with fail-fast semantics.
+5. While the parallel steps are still running, the scripts emit periodic heartbeat updates so you can tell that work is still in progress.
+6. If any command fails, fix the issue, rerun the script, and report the failing output.
+7. Confirm completion only when all commands succeed with no remaining issues.
 
 ## Manual workflow
 
 - If dependencies are not installed or have changed, run `make sync` first to install dev requirements via `uv`.
-- Run from the repository root in this order: `make format`, `make lint`, `make typecheck`, `make tests`.
+- Run from the repository root with `make format` first, then `make lint`, `make typecheck`, and `make tests`.
 - Do not skip steps; stop and fix issues immediately when a command fails.
+- If you run the steps manually, you may parallelize `make lint`, `make typecheck`, and `make tests` after `make format` completes, but you must stop the remaining steps as soon as one fails.
 - Re-run the full stack after applying fixes so the commands execute in the required order.
 
 ## Resources
 
 ### scripts/run.sh
 
-- Executes the full verification sequence with fail-fast semantics from the repository root. Prefer this entry point to ensure the required commands run in the correct order.
+- Executes `make format` first, then runs `make lint`, `make typecheck`, and `make tests` in parallel with fail-fast semantics from the repository root. It also emits periodic heartbeat updates while the parallel steps are still running. Prefer this entry point to preserve the required ordering while reducing total runtime.
 
 ### scripts/run.ps1
 
-- Windows-friendly wrapper that runs the same verification sequence with fail-fast semantics. Use from PowerShell with execution policy bypass if required by your environment.
+- Windows-friendly wrapper that runs the same sequence with `make format` first and the remaining steps in parallel with fail-fast semantics, plus periodic heartbeat updates while work is still running. Use from PowerShell with execution policy bypass if required by your environment.

.agents/skills/code-change-verification/agents/openai.yaml

@@ -0,0 +1,4 @@
+interface:
+  display_name: "Code Change Verification"
+  short_description: "Run the required local verification stack"
+  default_prompt: "Use $code-change-verification to run the required local verification stack and report any failures."

.agents/skills/code-change-verification/scripts/run.ps1

@@ -11,28 +11,198 @@ try {
 }
 
 if (-not $repoRoot) {
-    $repoRoot = Resolve-Path (Join-Path $scriptDir "..\\..\\..\\..")
+    $repoRoot = (Resolve-Path (Join-Path $scriptDir "..\\..\\..\\..")).Path
+} else {
+    $repoRoot = ([string]$repoRoot).Trim()
 }
 
 Set-Location $repoRoot
 
+$logDir = Join-Path ([System.IO.Path]::GetTempPath()) ("code-change-verification-" + [System.Guid]::NewGuid().ToString("N"))
+New-Item -ItemType Directory -Path $logDir | Out-Null
+
+$steps = New-Object System.Collections.Generic.List[object]
+$heartbeatIntervalSeconds = 10
+if ($env:CODE_CHANGE_VERIFICATION_HEARTBEAT_SECONDS) {
+    $heartbeatIntervalSeconds = [int]$env:CODE_CHANGE_VERIFICATION_HEARTBEAT_SECONDS
+}
+
+function Resolve-MakeInvocation {
+    $command = Get-Command make -ErrorAction Stop
+
+    while ($command.CommandType -eq [System.Management.Automation.CommandTypes]::Alias) {
+        $command = $command.ResolvedCommand
+    }
+
+    if ($command.CommandType -in @(
+        [System.Management.Automation.CommandTypes]::Application,
+        [System.Management.Automation.CommandTypes]::ExternalScript
+    )) {
+        $commandPath = if ($command.Path) { $command.Path } else { $command.Source }
+        return [PSCustomObject]@{
+            FilePath = $commandPath
+            ArgumentList = @()
+        }
+    }
+
+    if ($command.CommandType -eq [System.Management.Automation.CommandTypes]::Function) {
+        $shellPath = (Get-Process -Id $PID).Path
+        if (-not $shellPath) {
+            throw "Unable to resolve the current PowerShell executable for make wrapper launches."
+        }
+
+        $wrapperPath = Join-Path $logDir "invoke-make.ps1"
+        $escapedRepoRoot = $repoRoot -replace "'", "''"
+        $wrapperTemplate = @'
+Set-StrictMode -Version Latest
+$ErrorActionPreference = "Stop"
+Set-Location -LiteralPath '{0}'
+function global:make {{
+{1}
+}}
+& make @args
+exit $LASTEXITCODE
+'@
+        $wrapperScript = $wrapperTemplate -f $escapedRepoRoot, $command.Definition.TrimEnd()
+        Set-Content -Path $wrapperPath -Value $wrapperScript -Encoding UTF8
+
+        return [PSCustomObject]@{
+            FilePath = $shellPath
+            ArgumentList = @("-NoLogo", "-NoProfile", "-File", $wrapperPath)
+        }
+    }
+
+    throw "code-change-verification: make must resolve to an application, script, alias, or function."
+}
+
+$script:MakeInvocation = Resolve-MakeInvocation
+
 function Invoke-MakeStep {
     param(
         [Parameter(Mandatory = $true)][string]$Step
     )
 
     Write-Host "Running make $Step..."
-    & make $Step
+    & $script:MakeInvocation.FilePath @($script:MakeInvocation.ArgumentList + $Step)
 
     if ($LASTEXITCODE -ne 0) {
-        Write-Error "code-change-verification: make $Step failed with exit code $LASTEXITCODE."
-        exit $LASTEXITCODE
+        Write-Host "code-change-verification: make $Step failed with exit code $LASTEXITCODE."
+        return $LASTEXITCODE
     }
+
+    return 0
+}
+
+function Start-MakeStep {
+    param(
+        [Parameter(Mandatory = $true)][string]$Step
+    )
+
+    $stdoutLogPath = Join-Path $logDir "$Step.stdout.log"
+    $stderrLogPath = Join-Path $logDir "$Step.stderr.log"
+    Write-Host "Running make $Step..."
+    $process = Start-Process -FilePath $script:MakeInvocation.FilePath -ArgumentList @($script:MakeInvocation.ArgumentList + $Step) -RedirectStandardOutput $stdoutLogPath -RedirectStandardError $stderrLogPath -PassThru
+    $steps.Add([PSCustomObject]@{
+        Name = $Step
+        Process = $process
+        StdoutLogPath = $stdoutLogPath
+        StderrLogPath = $stderrLogPath
+        StartTime = Get-Date
+    })
 }
 
-Invoke-MakeStep -Step "format"
-Invoke-MakeStep -Step "lint"
-Invoke-MakeStep -Step "typecheck"
-Invoke-MakeStep -Step "tests"
+function Stop-RunningSteps {
+    foreach ($step in $steps) {
+        if ($null -eq $step.Process) {
+            continue
+        }
+
+        & taskkill /PID $step.Process.Id /T /F *> $null
+    }
+
+    foreach ($step in $steps) {
+        if ($null -eq $step.Process) {
+            continue
+        }
+
+        try {
+            $step.Process.WaitForExit()
+        } catch {
+        }
+    }
+}
+
+function Wait-ForParallelSteps {
+    $pending = New-Object System.Collections.Generic.List[object]
+    foreach ($step in $steps) {
+        $pending.Add($step)
+    }
+    $nextHeartbeatAt = (Get-Date).AddSeconds($heartbeatIntervalSeconds)
+
+    while ($pending.Count -gt 0) {
+        foreach ($step in @($pending)) {
+            $step.Process.Refresh()
+            if (-not $step.Process.HasExited) {
+                continue
+            }
+
+            $duration = [int]((Get-Date) - $step.StartTime).TotalSeconds
+            if ($step.Process.ExitCode -eq 0) {
+                Write-Host "make $($step.Name) passed in ${duration}s."
+                [void]$pending.Remove($step)
+                continue
+            }
+
+            Write-Host "code-change-verification: make $($step.Name) failed with exit code $($step.Process.ExitCode) after ${duration}s."
+            if (Test-Path $step.StderrLogPath) {
+                Write-Host "--- $($step.Name) stderr log (last 80 lines) ---"
+                Get-Content $step.StderrLogPath -Tail 80
+            }
+            if (Test-Path $step.StdoutLogPath) {
+                Write-Host "--- $($step.Name) stdout log (last 80 lines) ---"
+                Get-Content $step.StdoutLogPath -Tail 80
+            }
+
+            Stop-RunningSteps
+            return $step.Process.ExitCode
+        }
+
+        if ($pending.Count -gt 0) {
+            if ((Get-Date) -ge $nextHeartbeatAt) {
+                $running = @()
+                foreach ($step in $pending) {
+                    $elapsed = [int]((Get-Date) - $step.StartTime).TotalSeconds
+                    $running += "$($step.Name) (${elapsed}s)"
+                }
+                Write-Host ("code-change-verification: still running: " + ($running -join ", ") + ".")
+                $nextHeartbeatAt = (Get-Date).AddSeconds($heartbeatIntervalSeconds)
+            }
+            Start-Sleep -Seconds 1
+        }
+    }
+
+    return 0
+}
+
+$exitCode = 0
+
+try {
+    $exitCode = Invoke-MakeStep -Step "format"
+    if ($exitCode -eq 0) {
+        Write-Host "Running make lint, make typecheck, and make tests in parallel..."
+        Start-MakeStep -Step "lint"
+        Start-MakeStep -Step "typecheck"
+        Start-MakeStep -Step "tests"
+
+        $exitCode = Wait-ForParallelSteps
+    }
+} finally {
+    Stop-RunningSteps
+    Remove-Item $logDir -Recurse -Force -ErrorAction SilentlyContinue
+}
+
+if ($exitCode -ne 0) {
+    exit $exitCode
+}
 
 Write-Host "code-change-verification: all commands passed."