Skip to content

Commit 91b39a0

Browse files
authored
Fix response payload type for PutSubmodelById (3.2 Port) (#602)
* Fixes PUT /shells/{aasIdentifier}/submodels/{submodelIdentifier} return type on 201 status * Fix response payload type for PutSubmodelById: status code 201 now returns a Submodel instead of a Reference * Corrects changelog * Fixes wrong version
1 parent 8542dd7 commit 91b39a0

4 files changed

Lines changed: 27 additions & 5 deletions

File tree

AssetAdministrationShellRepositoryServiceSpecification/V3.2_SSP-001.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,7 @@ paths:
572572
required: true
573573
responses:
574574
'201':
575-
description: Submodel reference created successfully
575+
description: Submodel created successfully
576576
headers:
577577
Location:
578578
description: URL of the newly created resource
@@ -581,7 +581,7 @@ paths:
581581
content:
582582
application/json:
583583
schema:
584-
$ref: 'https://api.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.2.0#/components/schemas/Reference'
584+
$ref: 'https://api.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.2#/components/schemas/Submodel'
585585
'204':
586586
description: Submodel updated successfully
587587
'400':

AssetAdministrationShellRepositoryServiceSpecification/V3.2_SSP-005.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ paths:
409409
required: true
410410
responses:
411411
'201':
412-
description: Submodel reference created successfully
412+
description: Submodel created successfully
413413
headers:
414414
Location:
415415
description: URL of the newly created resource
@@ -418,7 +418,7 @@ paths:
418418
content:
419419
application/json:
420420
schema:
421-
$ref: 'https://api.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.2.0#/components/schemas/Reference'
421+
$ref: 'https://api.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.2.0#/components/schemas/Submodel'
422422
'204':
423423
description: Submodel updated successfully
424424
'400':

Entire-API-Collection/V3.2.yaml

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3390,7 +3390,7 @@ paths:
33903390
put:
33913391
tags:
33923392
- Asset Administration Shell Repository API
3393-
summary: Updates the Submodel
3393+
summary: Creates or updates the Submodel
33943394
operationId: PutSubmodelById_AasRepository
33953395
x-semanticIds:
33963396
- https://admin-shell.io/aas/API/PutSubmodelById/3/2
@@ -3402,6 +3402,17 @@ paths:
34023402
$ref: 'https://api.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.2.0#/components/schemas/Submodel'
34033403
required: true
34043404
responses:
3405+
'201':
3406+
description: Submodel created successfully
3407+
headers:
3408+
Location:
3409+
description: URL of the newly created resource
3410+
schema:
3411+
type: string
3412+
content:
3413+
application/json:
3414+
schema:
3415+
$ref: 'https://api.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.2.0#/components/schemas/Submodel'
34053416
'204':
34063417
description: Submodel updated successfully
34073418
'400':

documentation/IDTA-01002-3/modules/ROOT/pages/changelog.adoc

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,17 @@ h|Operation h|Kind of Change h|Comment
6464
|===
6565

6666

67+
== Changes w.r.t. V3.1.2 to V3.1.3
68+
69+
Major Changes:
70+
71+
* ...
72+
73+
74+
Minor Changes:
75+
76+
* Fixed the response payload type of `PutSubmodelById` in the Asset Administration Shell Repository OpenAPI files: status code `201` now returns a `Submodel` instead of a `Reference`. (https://github.com/admin-shell-io/aas-specs-api/issues/601[#601])
77+
6778

6879
== Changes w.r.t. V3.1.1 to V3.1.2
6980

0 commit comments

Comments
 (0)