Skip to content

[V3.1.3 Backport] fix(schema): align date/time operators with BNF; widen timeLiteralPattern #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebbader-sap wants to merge 2 commits into
base: IDTA-01001-3-1-3_working
Choose a base branch
from
+11 −10
Open

[V3.1.3 Backport] fix(schema): align date/time operators with BNF; widen timeLiteralPattern #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e5cc13
fix(schema): correct Value semantics for $dayOfWeek/$dayOfMonth/$mont…
aorzelskiGH Apr 17, 2026
89368a3
docs: add changelog entry for date/time schema alignment
sebbader-sap May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions documentation/IDTA-01002-3/modules/ROOT/pages/changelog.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ Major Changes:

Minor Changes:

* fix: Aligned date/time extraction functions (`$dayOfWeek`, `$dayOfMonth`, `$month`, `$year`) in JSON Schema to accept all `dateTimeOperand` types per BNF grammar, and widened `timeLiteralPattern` to support fractional seconds.

@BirgitBoss BirgitBoss Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need fractional seconds?

* fix: Wrong ServiceSpecificationProfileEnum values for v3.0 profiles. (https://github.com/admin-shell-io/aas-specs-api/issues/526[#526])
* removed: Remove TREE. (https://github.com/admin-shell-io/aas-specs-api/issues/537)
* fix: fixed FILTER object in json schema & fixed inconsistencies in BNF (https://github.com/admin-shell-io/aas-specs-api/issues/547)
Expand Down
10 changes: 5 additions & 5 deletions documentation/IDTA-01002-3/modules/ROOT/pages/schema.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"timeLiteralPattern": {
"type": "string",
"pattern": "^[0-9][0-9]:[0-9][0-9](:[0-9][0-9])?$"
"pattern": "^[0-9]{2}:[0-9]{2}(:[0-9]{2})?(\\.[0-9]+)?$"
},
"Value": {
"type": "object",
Expand Down Expand Up @@ -70,16 +70,16 @@
"$ref": "#/definitions/Value"
},
"$dayOfWeek": {
"$ref": "#/definitions/dateTimeLiteralPattern"
"$ref": "#/definitions/Value"

@BirgitBoss BirgitBoss Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it Value and not just string? Same question for all date related fields

},
"$dayOfMonth": {
"$ref": "#/definitions/dateTimeLiteralPattern"
"$ref": "#/definitions/Value"
},
"$month": {
"$ref": "#/definitions/dateTimeLiteralPattern"
"$ref": "#/definitions/Value"
},
"$year": {
"$ref": "#/definitions/dateTimeLiteralPattern"
"$ref": "#/definitions/Value"
}
},
"oneOf": [
Expand Down
10 changes: 5 additions & 5 deletions documentation/IDTA-01002-3/modules/ROOT/partials/query-json-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"timeLiteralPattern": {
"type": "string",
"pattern": "^[0-9][0-9]:[0-9][0-9](:[0-9][0-9])?$"
"pattern": "^[0-9]{2}:[0-9]{2}(:[0-9]{2})?(\\.[0-9]+)?$"
},
"Value": {
"type": "object",
Expand Down Expand Up @@ -67,16 +67,16 @@
"$ref": "#/definitions/Value"
},
"$dayOfWeek": {
"$ref": "#/definitions/dateTimeLiteralPattern"
"$ref": "#/definitions/Value"
},
"$dayOfMonth": {
"$ref": "#/definitions/dateTimeLiteralPattern"
"$ref": "#/definitions/Value"
},
"$month": {
"$ref": "#/definitions/dateTimeLiteralPattern"
"$ref": "#/definitions/Value"
},
"$year": {
"$ref": "#/definitions/dateTimeLiteralPattern"
"$ref": "#/definitions/Value"
}
},
"oneOf": [
Expand Down
Loading