Skip to content

Removes wrong 404 status code for getAllSubmodelDescriptors (3.2 Port)#619

Merged
sebbader-sap merged 3 commits into
IDTA-01002-3-2_workingfrom
aaronzi/issue-597_3-2-port
Jun 5, 2026
Merged

Removes wrong 404 status code for getAllSubmodelDescriptors (3.2 Port)#619
sebbader-sap merged 3 commits into
IDTA-01002-3-2_workingfrom
aaronzi/issue-597_3-2-port

Conversation

@aaronzi

@aaronzi aaronzi commented May 21, 2026

Copy link
Copy Markdown
Member

This pull request aligns the Submodel Registry response contract for GET /submodel-descriptors with collection semantics.
When no submodel descriptors exist, the endpoint returns 200 OK with an empty result set, so documenting 404 Not Found for this operation was misleading. This PR removes that ambiguity and updates the changelog accordingly.

API Specification Fixes:

  • Removed 404 Not Found from GET /submodel-descriptors in the Submodel Registry full profile:
    V3.2_SSP-001.yaml
  • Removed 404 Not Found from GET /submodel-descriptors in the Submodel Registry read profile:
    V3.2_SSP-002.yaml
  • Applied the same change in the aggregated OpenAPI collection:
    V3.2.yaml

Documentation Updates:

  • Added a 3.1.3 minor-change entry describing this fix and referencing issue 597:
    changelog.adoc

Related Issues

See #597

Cherry picked 30bd9be and 0d21dcb from #617

IMPORTANT!

Merge #618 first

@aaronzi aaronzi added this to the 3.1.3 milestone May 21, 2026

@BirgitBoss BirgitBoss left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, only one thing; I did not find the 403 fix in the changelog
The changelog contains more changes than the PR, so probably several PRs covered in changelog?

@aaronzi

aaronzi commented May 28, 2026

Copy link
Copy Markdown
Member Author

@BirgitBoss I tried to create the PRs in a way that merging them after each other is possible without causing merge conflicts. But this means that more stuff is included than what the PR actually fixes (e.g. change log entries from previous PRs). This is why the description says merge xyz first. I can change that if it's wanted.

The 404 fix is documented in the changelog.

@sebbader-sap sebbader-sap merged commit 267e45a into IDTA-01002-3-2_working Jun 5, 2026
1 check passed
@sebbader-sap sebbader-sap deleted the aaronzi/issue-597_3-2-port branch June 5, 2026 13:46
@sebbader-sap sebbader-sap modified the milestones: 3.1.3, 3.2 Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants