Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve route and right specification #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
improve route and right specification #70
Changes from all commits
c313b2778e91829fc6f43File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 223 in documentation/IDTA-01004/modules/ROOT/pages/access-rule-model.adoc
Attribute not defined within project
Check warning
Code scanning / QDJVMC
Attribute not defined within project Warning documentation
Check warning on line 224 in documentation/IDTA-01004/modules/ROOT/pages/access-rule-model.adoc
Attribute not defined within project
Check warning
Code scanning / QDJVMC
Attribute not defined within project Warning documentation
Check warning on line 7 in documentation/IDTA-01004/modules/ROOT/pages/annex/route-examples.adoc
Typo
Check warning
Code scanning / QDJVMC
Typo Warning documentation
Check warning on line 11 in documentation/IDTA-01004/modules/ROOT/pages/annex/route-examples.adoc
Description exists inspection for Antora page
Check warning
Code scanning / QDJVMC
Description exists inspection for Antora page Warning documentation
Check warning on line 34 in documentation/IDTA-01004/modules/ROOT/pages/annex/route-examples.adoc
Attribute not defined within project
Check warning on line 34 in documentation/IDTA-01004/modules/ROOT/pages/annex/route-examples.adoc
Attribute not defined within project
Check warning
Code scanning / QDJVMC
Attribute not defined within project Warning documentation
Check warning
Code scanning / QDJVMC
Attribute not defined within project Warning documentation
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expected examples like
because it is easier from an example to see what exactly to write as value for ROUTE - is my example correct? It could also be added to the other example file.
So rule above would allow me to execute
POST /api/v3/shellsandPUT /api/v3/shellsas well asPOST /api/v3/submodelsPUT /api/v3/submodelsandPOST /api/v3/submodels/{submodelIdentifier}and so onThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your example is correct. But be aware that for post
{submodelIdentifier}is not needed and for PUT it is needed.So correct endpoints would be:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was not clear for me from the structure that you assume that the examples in this section all require CREATE Rights. Please add as sentence at the beginning, similar to other sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a leading sentence before each RIGHT example section
Check warning on line 70 in documentation/IDTA-01004/modules/ROOT/pages/annex/route-examples.adoc
Typo
Check warning
Code scanning / QDJVMC
Typo Warning documentation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.