the UMAPI has never supported "add all groups"

Author: adorton-adobe

tests/test_functional.py

@@ -170,19 +170,6 @@ def test_add_products():
                                 "user": "user@example.com"}
 
 
-def test_add_to_groups_all():
-    user = UserAction(user="user@example.com")
-    user.add_to_groups(all_groups=True)
-    assert user.wire_dict() == {"do": [{"add": "all"}],
-                                "user": "user@example.com"}
-
-
-def test_add_to_groups_all_error():
-    user = UserAction(user="user@example.com")
-    with pytest.raises(ValueError):
-        user.add_to_groups(all_groups=True, groups=["Photoshop"])
-
-
 def test_add_to_usergroups():
     user = UserAction(user="user@example.com")
     user.add_to_groups(groups=["Photoshop", "Illustrator"])

umapi_client/functional.py

@@ -134,22 +134,13 @@ def update(self, email=None, username=None, first_name=None, last_name=None):
                 updates[k] = v
         return self.append(update=updates)
 
-    def add_to_groups(self, groups=None, all_groups=False):
+    def add_to_groups(self, groups=list()):
         """
-        Add user to some (typically PLC) groups.  Note that, if you add to no groups, the effect
-        is simply to do an "add to organization Everybody group", so we let that be done.
+        Add user to one or more groups
         :param groups: list of group names the user should be added to
-        :param all_groups: a boolean meaning add to all (don't specify groups)
         :return: the User, so you can do User(...).add_to_groups(...).???()
         """
-        if all_groups:
-            if groups:
-                raise ArgumentError("When adding to all groups, do not specify specific groups")
-            glist = "all"
-        else:
-            if not groups:
-                groups = []
-            glist = {"group": [group for group in groups]}
+        glist = {"group": [group for group in groups]}
         return self.append(add=glist)
 
     def remove_from_groups(self, groups=None, all_groups=False):