UMAPI never supported this

Author: adorton-adobe

tests/test_functional.py

@@ -232,18 +232,6 @@ def test_add_to_products():
     assert group.wire_dict() == {"do": [{"add": {"productConfiguration": ["Photoshop", "Illustrator"]}}],
                                  "usergroup": "SampleUsers"}
 
-def test_add_to_products_all():
-    group = GroupAction(group_name="SampleUsers")
-    group.add_to_products(all_products=True)
-    assert group.wire_dict() == {"do": [{"add": "all"}],
-                                 "usergroup": "SampleUsers"}
-
-
-def test_add_to_products_all_error():
-    group = GroupAction(group_name="SampleUsers")
-    with pytest.raises(ValueError):
-        group.add_to_products(all_products=True, products=["Photoshop"])
-
 
 def test_remove_from_products():
     group = GroupAction(group_name="SampleUsers")
@@ -252,19 +240,6 @@ def test_remove_from_products():
                                  "usergroup": "SampleUsers"}
 
 
-def test_remove_from_products_all():
-    group = GroupAction(group_name="SampleUsers")
-    group.remove_from_products(all_products=True)
-    assert group.wire_dict() == {"do": [{"remove": "all"}],
-                                 "usergroup": "SampleUsers"}
-
-
-def test_remove_from_products_all_error():
-    group = GroupAction(group_name="SampleUsers")
-    with pytest.raises(ValueError):
-        group.remove_from_products(all_products=True, products=["Photoshop"])
-
-
 def test_add_users():
     group = GroupAction(group_name="SampleUsers")
     group.add_users(users=["user1@example.com", "user2@mydomain.net"])

umapi_client/functional.py

@@ -237,38 +237,22 @@ def __init__(self, group_name=None, **kwargs):
             ArgumentError("You must provide the name of the group")
         Action.__init__(self, usergroup=group_name, **kwargs)
 
-    def add_to_products(self, products=None, all_products=False):
+    def add_to_products(self, products):
         """
         Add user group to some product license configuration groups (PLCs), or all of them.
         :param products: list of product names the user should be added to
-        :param all_products: a boolean meaning add to all (don't specify products in this case)
         :return: the Group, so you can do Group(...).add_to_products(...).add_users(...)
         """
-        if all_products:
-            if products:
-                raise ArgumentError("When adding to all products, do not specify specific products")
-            plist = "all"
-        else:
-            if not products:
-                raise ArgumentError("You must specify products to which to add the user group")
-            plist = {"productConfiguration": [product for product in products]}
+        plist = {"productConfiguration": list(products)}
         return self.append(add=plist)
 
-    def remove_from_products(self, products=None, all_products=False):
+    def remove_from_products(self, products):
         """
         Remove user group from some product license configuration groups (PLCs), or all of them.
         :param products: list of product names the user group should be removed from
-        :param all_products: a boolean meaning remove from all (don't specify products in this case)
         :return: the Group, so you can do Group(...).remove_from_products(...).add_users(...)
         """
-        if all_products:
-            if products:
-                raise ArgumentError("When removing from all products, do not specify specific products")
-            plist = "all"
-        else:
-            if not products:
-                raise ArgumentError("You must specify products from which to remove the user group")
-            plist = {"productConfiguration": [product for product in products]}
+        plist = {"productConfiguration": list(products)}
         return self.append(remove=plist)
 
     def add_users(self, users=None):