Skip to content

Commit 7eea548

Browse files
committed
rename "UserGroupAction" to "GroupAction"
1 parent 68a37d0 commit 7eea548

4 files changed

Lines changed: 21 additions & 21 deletions

File tree

tests/test_connections.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
from umapi_client import Connection
3232
from umapi_client import ArgumentError, UnavailableError, ServerError, RequestError
33-
from umapi_client import UserAction, IdentityType, UserGroupAction
33+
from umapi_client import UserAction, IdentityType, GroupAction
3434
from umapi_client import __version__ as umapi_version
3535
from umapi_client.auth import JWTAuth
3636

@@ -501,7 +501,7 @@ def test_split_remove_all():
501501
def test_split_group_action():
502502
user_template = "user.{}@example.com"
503503
add_users = [user_template.format(n+1) for n in range(0, 25)]
504-
group = UserGroupAction(group_name="Test Group")
504+
group = GroupAction(group_name="Test Group")
505505
group.add_users(users=add_users)
506506
assert group.maybe_split_groups(10) is True
507507
assert len(group.commands) == 3

tests/test_functional.py

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
from umapi_client import ArgumentError, RequestError
2727
from umapi_client import Connection
2828
from umapi_client import IdentityType
29-
from umapi_client import UserAction, UserGroupAction
29+
from umapi_client import UserAction, GroupAction
3030
from umapi_client import UsersQuery
3131

3232

@@ -227,87 +227,87 @@ def test_remove_from_organization_delete_adobeid():
227227
"useAdobeID": True}
228228

229229
def test_add_to_products():
230-
group = UserGroupAction(group_name="SampleUsers")
230+
group = GroupAction(group_name="SampleUsers")
231231
group.add_to_products(products=["Photoshop", "Illustrator"])
232232
assert group.wire_dict() == {"do": [{"add": {"productConfiguration": ["Photoshop", "Illustrator"]}}],
233233
"usergroup": "SampleUsers"}
234234

235235
def test_add_to_products_all():
236-
group = UserGroupAction(group_name="SampleUsers")
236+
group = GroupAction(group_name="SampleUsers")
237237
group.add_to_products(all_products=True)
238238
assert group.wire_dict() == {"do": [{"add": "all"}],
239239
"usergroup": "SampleUsers"}
240240

241241

242242
def test_add_to_products_all_error():
243-
group = UserGroupAction(group_name="SampleUsers")
243+
group = GroupAction(group_name="SampleUsers")
244244
with pytest.raises(ValueError):
245245
group.add_to_products(all_products=True, products=["Photoshop"])
246246

247247

248248
def test_remove_from_products():
249-
group = UserGroupAction(group_name="SampleUsers")
249+
group = GroupAction(group_name="SampleUsers")
250250
group.remove_from_products(products=["Photoshop", "Illustrator"])
251251
assert group.wire_dict() == {"do": [{"remove": {"productConfiguration": ["Photoshop", "Illustrator"]}}],
252252
"usergroup": "SampleUsers"}
253253

254254

255255
def test_remove_from_products_all():
256-
group = UserGroupAction(group_name="SampleUsers")
256+
group = GroupAction(group_name="SampleUsers")
257257
group.remove_from_products(all_products=True)
258258
assert group.wire_dict() == {"do": [{"remove": "all"}],
259259
"usergroup": "SampleUsers"}
260260

261261

262262
def test_remove_from_products_all_error():
263-
group = UserGroupAction(group_name="SampleUsers")
263+
group = GroupAction(group_name="SampleUsers")
264264
with pytest.raises(ValueError):
265265
group.remove_from_products(all_products=True, products=["Photoshop"])
266266

267267

268268
def test_add_users():
269-
group = UserGroupAction(group_name="SampleUsers")
269+
group = GroupAction(group_name="SampleUsers")
270270
group.add_users(users=["user1@example.com", "user2@mydomain.net"])
271271
assert group.wire_dict() == {"do": [{"add": {"user": ["user1@example.com", "user2@mydomain.net"]}}],
272272
"usergroup": "SampleUsers"}
273273

274274

275275
def test_add_users_error():
276-
group = UserGroupAction(group_name="SampleUsers")
276+
group = GroupAction(group_name="SampleUsers")
277277
with pytest.raises(ValueError):
278278
group.add_users(users=[])
279279

280280

281281
def test_remove_users():
282-
group = UserGroupAction(group_name="SampleUsers")
282+
group = GroupAction(group_name="SampleUsers")
283283
group.remove_users(users=["user1@example.com", "user2@mydomain.net"])
284284
assert group.wire_dict() == {"do": [{"remove": {"user": ["user1@example.com", "user2@mydomain.net"]}}],
285285
"usergroup": "SampleUsers"}
286286

287287

288288
def test_remove_users_error():
289-
group = UserGroupAction(group_name="SampleUsers")
289+
group = GroupAction(group_name="SampleUsers")
290290
with pytest.raises(ValueError):
291291
group.remove_users(users=[])
292292

293293

294294
def test_create_user_group():
295-
group = UserGroupAction(group_name="Test Group")
295+
group = GroupAction(group_name="Test Group")
296296
group.create(description="Test Group Description")
297297
assert group.wire_dict() == {'do': [{'createUserGroup': {'option': 'ignoreIfAlreadyExists',
298298
'description': 'Test Group Description'}}],
299299
'usergroup': 'Test Group'}
300300

301301

302302
def test_create_user_group_error():
303-
group = UserGroupAction(group_name="Test Group")
303+
group = GroupAction(group_name="Test Group")
304304
group.create(description="Test Group Description")
305305
with pytest.raises(ArgumentError):
306306
group.create()
307307

308308

309309
def test_invalid_user_group_name():
310-
group = UserGroupAction(group_name="_Invalid Group Name")
310+
group = GroupAction(group_name="_Invalid Group Name")
311311
with pytest.raises(ArgumentError):
312312
group.create()
313313
with pytest.raises(ArgumentError):
@@ -320,23 +320,23 @@ def test_long_user_group_name():
320320
aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.
321321
Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur
322322
sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum."""
323-
group = UserGroupAction(group_name=long_group_name)
323+
group = GroupAction(group_name=long_group_name)
324324
with pytest.raises(ArgumentError):
325325
group.create()
326326
with pytest.raises(ArgumentError):
327327
group.update(name=long_group_name)
328328

329329

330330
def test_update_user_group():
331-
group = UserGroupAction(group_name="Test Group")
331+
group = GroupAction(group_name="Test Group")
332332
group.update(name="Renamed Test Group", description="Test Group Description")
333333
assert group.wire_dict() == {'do': [{'updateUserGroup': {'name': 'Renamed Test Group',
334334
'description': 'Test Group Description'}}],
335335
'usergroup': 'Test Group'}
336336

337337

338338
def test_delete_user_group():
339-
group = UserGroupAction("Test Group")
339+
group = GroupAction("Test Group")
340340
group.delete()
341341
assert group.wire_dict() == {'do': [{'deleteUserGroup': {}}],
342342
'usergroup': 'Test Group'}

umapi_client/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,5 @@
2424
from .error import BatchError, ClientError, RequestError, ServerError, UnavailableError, ArgumentError
2525
from .functional import IdentityType, IfAlreadyExistsOption
2626
from .functional import UserAction, UserQuery, UsersQuery
27-
from .functional import UserGroupAction, GroupsQuery
27+
from .functional import GroupAction, GroupsQuery
2828
from .version import __version__

umapi_client/functional.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ def __init__(self, connection, user_string, domain=None):
207207
QuerySingle.__init__(self, connection=connection, object_type="user", url_params=[user_string], query_params=qparam)
208208

209209

210-
class UserGroupAction(Action):
210+
class GroupAction(Action):
211211
"""
212212
A sequence of commands to perform on a single user group.
213213
"""

0 commit comments

Comments
 (0)