Skip to content

Commit 8da943e

Browse files
committed
minor fixes
1 parent 5554327 commit 8da943e

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

user_sync/rules.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -480,14 +480,13 @@ def sync_umapi_users(self, umapi_connectors):
480480
else:
481481
primary_adds_by_user_key = self.update_umapi_users_for_connector(umapi_info, umapi_connector)
482482
for user_key, groups_to_add in six.iteritems(primary_adds_by_user_key):
483-
if exclude_unmapped_users == True and not groups_to_add:
483+
if exclude_unmapped_users and not groups_to_add:
484484
# If user is not part of any group and ignore outcast is enabled. Do not create user.
485-
pass
486-
else:
487-
# We always create every user in the primary umapi, because it's believed to own the directories.
488-
self.logger.info('Creating user with user key: %s', user_key)
489-
self.primary_users_created.add(user_key)
490-
self.create_umapi_user(user_key, groups_to_add, umapi_info, umapi_connector)
485+
continue
486+
# We always create every user in the primary umapi, because it's believed to own the directories.
487+
self.logger.info('Creating user with user key: %s', user_key)
488+
self.primary_users_created.add(user_key)
489+
self.create_umapi_user(user_key, groups_to_add, umapi_info, umapi_connector)
491490

492491
# then sync the secondary connectors
493492
for umapi_name, umapi_connector in six.iteritems(umapi_connectors.get_secondary_connectors()):

0 commit comments

Comments
 (0)