Skip to content

Commit 70eb61b

Browse files
sirughclaude
andcommitted
chore: remove dead rettime mock, fix license header typo
- Delete test/__mocks__/rettime.cjs — never loaded (wrong directory for auto-mocking, no moduleNameMapper, msw CJS doesn't require rettime directly) - Fix Apache 2.0 header in utils.test.mjs: 'LICENSE' → 'License' Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 9eed611 commit 70eb61b

5 files changed

Lines changed: 114 additions & 47 deletions

File tree

.claude/settings.local.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"permissions": {
3+
"allow": [
4+
"mcp__adobe-slack__slack_get_thread_replies",
5+
"mcp__adobe-slack__slack_reply_to_thread"
6+
]
7+
}
8+
}
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
{
2+
"project": {
3+
"id": "4566206088345479983",
4+
"name": "911GhostwhiteSheep",
5+
"title": "Storefront Prerenderer PDP and PLP",
6+
"org": {
7+
"id": "3655614",
8+
"name": "Adobe Commerce Optimizer Internal",
9+
"ims_org_id": "77C920686809469C0A495FE5@AdobeOrg"
10+
},
11+
"workspace": {
12+
"id": "4566206088345506001",
13+
"name": "Stage",
14+
"title": "Stage",
15+
"action_url": "https://3655614-911ghostwhitesheep-stage.adobeioruntime.net",
16+
"app_url": "https://3655614-911ghostwhitesheep-stage.adobeio-static.net",
17+
"details": {
18+
"credentials": [],
19+
"services": [],
20+
"runtime": {
21+
"namespaces": [
22+
{
23+
"name": "3655614-911ghostwhitesheep-stage",
24+
"auth": "92f9ac16-885e-4364-93cc-930399f71043:kPANXAtLi2wNmF6Ps58v41Xsf4gHKl2W3bu5WppB22QbIH37085J1dxDrMqod4bh"
25+
}
26+
]
27+
},
28+
"events": { "registrations": [] },
29+
"mesh": {}
30+
}
31+
}
32+
}
33+
}

KT Questions.md

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
# KT Questions
2+
3+
## Existing
4+
5+
1. What is the use case for the setup wizard?
6+
1. What is the difference between the wizard and bin/setup/index.js?
7+
8+
one is ui, one is api but there may be overlap - please call out in issues
9+
10+
1. Why is the roles defined in setup/index.js different than the roles defined in setup-wizard.js?
11+
12+
only need publish
13+
14+
1. https://prerender.aem-storefront.com/ - what is this?
15+
16+
- repo in adobe-rnd: https://github.com/adobe-rnd/aem-commerce-prerender-ui
17+
- gets url of overlay where markup is stored, automatically used by wizard but before wizard, you had to manually set it
18+
- form submit at end of wizard to prerender.aem-storefront.com with creds to create context in local storage for interface
19+
20+
1. What is content url, products template, and commerce store url and why do they need defined in the setup wizard?
21+
22+
They should prepopulate from org/site - if they did not it is a bug.
23+
Only relevant if merchant has different paths.
24+
path format likely needs to be changed.
25+
Template depends on locales or not.
26+
27+
1. Is there any code that needs removed or refactored?
28+
29+
github issues reference relevant.
30+
do not consider low priority issues (see label)
31+
others, recommend to start working
32+
generic code cleanup issue would be good
33+
for prerender setup, and "prerender"
34+
35+
1. What do you wish could be done before you return from PTO
36+
37+
p0:
38+
39+
- Alberto is mostly worried about existing customer support.
40+
- In JIRA, priority tickets such as to fix DKV.
41+
42+
p1: next/generic ssg issues, cleanup, etc.
43+
44+
In reference impl, we do not show anything more than the markup.
45+
The rest of the pdp page loads as usual. Up to customer to embed further information.
46+
47+
1. How can I view, assess, and regenerate the index file?
48+
49+
1. How can I refresh products?
50+
51+
52+
53+
54+
## New Features
55+
56+
1. If I wanted to add a new fetcher for categories, where do I put that? actions/fetch-all-categories/index.js?
57+
58+
1. Could we obtain more "dynamic" things, such as the graphql operations, templates, etc, from a service? Queries can change, and we have hardcoded them here.
59+
1. Since product details query are prerendered, what happens if customer has custom query? For example, if they want to extend or override certain fields?
60+
61+
Yes - make issue. It is ref impl, but maybe ways to make more generic/customizable rather than having to change code files directly.
62+
63+
1. Is there a reason we did not use a multi-tenant approach?
64+
65+
* catalog service public events were not yet available when this was built.
66+
* all events trigger change, so would be too noisy - would have to keep a cache/etc to reduce
67+
* poller allows customer to be in control of what/when they want to trigger
68+
* rendering process is heavily customized
69+
70+
1. Would you be interested in moving UI flows to storefront-tools?
71+
72+
Yes - shared with Alberto

test/__mocks__/rettime.cjs

Lines changed: 0 additions & 46 deletions
This file was deleted.

test/utils.test.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ you may not use this file except in compliance with the License. You may obtain
55
of the License at http://www.apache.org/licenses/LICENSE-2.0
66
77
Unless required by applicable law or agreed to in writing, software distributed under
8-
the LICENSE is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS
8+
the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS
99
OF ANY KIND, either express or implied. See the License for the specific language
1010
governing permissions and limitations under the License.
1111
*/

0 commit comments

Comments
 (0)