Attempt at fixing memory leak related to foreignObjects and nested SVG

Edward Turpin · Edward Turpin · commit 22e1017f62bf · 2021-08-23T13:13:39.000-05:00
elements.
diff --git a/src/svg.js b/src/svg.js
@@ -1323,7 +1323,7 @@ setInterval(function () {
     for (var key in hub) if (hub[has](key)) {
         var el = hub[key],
             node = el.node;
-        if (el.type != "svg" && !node.ownerSVGElement || el.type == "svg" && (!node.parentNode || "ownerSVGElement" in node.parentNode && !node.ownerSVGElement)) {
+        if (!node.isConnected) {
             delete hub[key];
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -1323,7 +1323,7 @@ setInterval(function () {`
`1323`	`1323`	`for (var key in hub) if (hub[has](key)) {`
`1324`	`1324`	`var el = hub[key],`
`1325`	`1325`	`node = el.node;`
`1326`		`- if (el.type != "svg" && !node.ownerSVGElement \|\| el.type == "svg" && (!node.parentNode \|\| "ownerSVGElement" in node.parentNode && !node.ownerSVGElement)) {`
	`1326`	`+ if (!node.isConnected) {`
`1327`	`1327`	`delete hub[key];`
`1328`	`1328`	`}`
`1329`	`1329`	`}`