Chore/maintenance for 5.2.0 ctd#3094
Open
afranken wants to merge 6 commits into
Open
Conversation
Java LSP is based on Eclipse.
Use spring-boot-maven-plugin with paketo buildpacks. This increases Docker image size, will try to optimize later.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs maintenance work for the 5.2.0 line by modernizing how the S3Mock OCI/Docker image is built (moving from a dedicated docker/ Maven module and shell scripts to Spring Boot Buildpacks), and by removing unused build/dependency scaffolding that existed to support the old image build.
Changes:
- Replace the legacy
docker/module +docker buildxscripts with Spring Boot Maven pluginbuild-imageprofiles inserver/(including multi-arch release publishing). - Drop the unused
software.amazon.awssdk:s3dependency from the server module and depend only on the AWS helper modules actually used (checksums,regions,utils, plusaws-crt-clientfor CRC64NVME). - Remove reactor/build-order “docker module” dependencies from
integration-testsandtestsupport/testcontainers, and adjust integration test container memory for Buildpack images.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
testsupport/testcontainers/pom.xml |
Removes the now-obsolete s3mock-docker dependency previously used for build ordering. |
server/pom.xml |
Drops AWS SDK s3 dependency; adds checksums + aws-crt-client; centralizes Buildpacks image env; adds build-docker-image and push-docker-image profiles. |
pom.xml |
Removes the docker module and related parent-level dependency/property now superseded by server-side Buildpacks image build. |
integration-tests/pom.xml |
Removes obsolete s3mock-docker dependency; increases container memory for Buildpack-based runtime. |
docker/stop-buildkit.sh |
Deleted (legacy buildx helper). |
docker/start-buildkit.sh |
Deleted (legacy buildx helper). |
docker/push-docker-image.sh |
Deleted (legacy buildx helper). |
docker/pom.xml |
Deleted (entire legacy docker module removed). |
docker/Dockerfile |
Deleted (replaced by Buildpacks-based image build). |
docker/build-docker-image.sh |
Deleted (legacy buildx helper). |
CHANGELOG.md |
Documents the dependency removal and the Docker image build modernization. |
AGENTS.md |
Updates repository guidance to reflect the new Buildpacks-based OCI image build approach. |
.gitignore |
Adds .factorypath to ignored IDE/build artifacts. |
.github/workflows/maven-release.yml |
Adds Buildx setup and provides Docker Hub credentials for the Buildpacks publish flow during releases. |
.github/dependabot.yml |
Removes Docker ecosystem updates since the Dockerfile/module is removed. |
.github/CONTRIBUTING.md |
Updates wording to reflect “Docker image build” rather than “Dockerfile” specifics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <BP_JVM_JLINK_ENABLED>true</BP_JVM_JLINK_ENABLED> | ||
| <!-- S3Mock does not use Spring Cloud Bindings; disable to remove the ~94MB layer. --> | ||
| <BP_SPRING_CLOUD_BINDINGS_DISABLED>true</BP_SPRING_CLOUD_BINDINGS_DISABLED> | ||
| <!-- Preserve the JVM flags previously set in the Dockerfile ENTRYPOINT. --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: