Skip to content

Commit a510ff9

Browse files
authored
CIF-2887 - Wrong page component in datalayer (#918)
* fixed page type for datalayer
1 parent 02dfc74 commit a510ff9

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

bundles/core/src/main/java/com/adobe/cq/commerce/core/components/internal/models/v1/page/AbstractPageDelegator.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import com.adobe.cq.wcm.core.components.models.NavigationItem;
2727
import com.adobe.cq.wcm.core.components.models.Page;
2828
import com.adobe.cq.wcm.core.components.models.datalayer.ComponentData;
29+
import com.adobe.cq.wcm.core.components.models.datalayer.builder.DataLayerBuilder;
2930
import com.fasterxml.jackson.annotation.JsonIgnore;
3031

3132
abstract class AbstractPageDelegator implements Page {
@@ -150,7 +151,12 @@ public String getId() {
150151

151152
@Override
152153
public ComponentData getData() {
153-
return getDelegate().getData();
154+
ComponentData data = getDelegate().getData();
155+
if (data == null) {
156+
return null;
157+
}
158+
159+
return DataLayerBuilder.extending(data).asPage().withType(this::getExportedType).build();
154160
}
155161

156162
@Override

bundles/core/src/test/java/com/adobe/cq/commerce/core/components/internal/models/v1/page/AbstractPageDelegatorTest.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import static junit.framework.Assert.assertNotNull;
3535
import static junit.framework.Assert.assertTrue;
3636
import static org.assertj.core.api.Assertions.assertThat;
37+
import static org.junit.Assert.assertNull;
3738
import static org.mockito.Mockito.doReturn;
3839
import static org.mockito.Mockito.mock;
3940
import static org.mockito.Mockito.when;
@@ -129,9 +130,12 @@ public void testDelegation() {
129130
when(mock.getId()).thenReturn("id");
130131
assertEquals("id", subject.getId());
131132

133+
assertNull(subject.getData());
132134
ComponentData data = mock(ComponentData.class);
135+
when(data.getId()).thenReturn("myId");
133136
when(mock.getData()).thenReturn(data);
134-
assertEquals(data, subject.getData());
137+
assertEquals(data.getId(), subject.getData().getId());
138+
assertEquals("type", subject.getData().getType());
135139

136140
when(mock.getAppliedCssClasses()).thenReturn("my-page__root");
137141
assertEquals("my-page__root", subject.getAppliedCssClasses());

0 commit comments

Comments
 (0)