address review comment: remove default region

Author: AjazSumaiya

src/commands/app/deploy.js

@@ -305,25 +305,28 @@ class Deploy extends BuildCommand {
   }
 
   async provisionDatabase (config, spinner, flags) {
-    const region = config.manifest?.full?.database?.region || 'amer'
+    const region = config.manifest?.full?.database?.region
+    const args = ['--yes']
 
-    if (!config.manifest?.full?.database?.region) {
-      spinner.info(chalk.green('No region is configured for the database, deploying in default region amer'))
+    if (region) {
+      args.unshift('--region', region)
     }
 
-    const message = `Deploying database for region '${region}'`
+    const message = region ? `Deploying database in region '${region}'` : 'Deploying database in default region'
 
     try {
       spinner.start(message)
 
       if (flags.verbose) {
-        spinner.info(chalk.dim(`Running: aio app db provision --region ${region} --yes`))
+        const commandStr = region ? `aio app db provision --region ${region} --yes` : 'aio app db provision --yes'
+        spinner.info(chalk.dim(`Running: ${commandStr}`))
         spinner.start(message)
       }
 
-      await this.config.runCommand('app:db:provision', ['--region', region, '--yes'])
+      await this.config.runCommand('app:db:provision', args)
 
-      spinner.succeed(chalk.green(`Deployed database for application in region '${region}'`))
+      const successMessage = region ? `Deployed database for application in region '${region}'` : 'Deployed database for application'
+      spinner.succeed(chalk.green(successMessage))
     } catch (error) {
       spinner.fail(chalk.red('Database deployment failed'))
       throw error

test/commands/app/deploy.test.js

@@ -1698,10 +1698,9 @@ describe('database provisioning', () => {
 
     const { spinner } = await runProvisionTest(config, flags)
 
-    expect(spinner.info).toHaveBeenCalledWith(expect.stringContaining('No region is configured for the database, deploying in default region amer'))
-    expect(spinner.start).toHaveBeenCalledWith('Deploying database for region \'amer\'')
-    expect(command.config.runCommand).toHaveBeenCalledWith('app:db:provision', ['--region', 'amer', '--yes'])
-    expect(spinner.succeed).toHaveBeenCalledWith(expect.stringContaining('Deployed database for application in region \'amer\''))
+    expect(spinner.start).toHaveBeenCalledWith('Deploying database in default region')
+    expect(command.config.runCommand).toHaveBeenCalledWith('app:db:provision', ['--yes'])
+    expect(spinner.succeed).toHaveBeenCalledWith(expect.stringContaining('Deployed database for application'))
   })
 
   test('should use configured region when specified in manifest', async () => {
@@ -1710,8 +1709,7 @@ describe('database provisioning', () => {
 
     const { spinner } = await runProvisionTest(config, flags)
 
-    expect(spinner.info).not.toHaveBeenCalledWith(expect.stringContaining('No region is configured for the database'))
-    expect(spinner.start).toHaveBeenCalledWith('Deploying database for region \'emea\'')
+    expect(spinner.start).toHaveBeenCalledWith('Deploying database in region \'emea\'')
     expect(command.config.runCommand).toHaveBeenCalledWith('app:db:provision', ['--region', 'emea', '--yes'])
     expect(spinner.succeed).toHaveBeenCalledWith(expect.stringContaining('Deployed database for application in region \'emea\''))
   })
@@ -1723,11 +1721,21 @@ describe('database provisioning', () => {
     const { spinner } = await runProvisionTest(config, flags)
 
     expect(spinner.info).toHaveBeenCalledWith(expect.stringContaining('Running: aio app db provision --region amer --yes'))
-    expect(spinner.info).not.toHaveBeenCalledWith(expect.stringContaining('No region is configured for the database'))
     expect(spinner.start).toHaveBeenCalledTimes(2) // Once initially, once after verbose info
     expect(spinner.succeed).toHaveBeenCalledWith(expect.stringContaining('Deployed database for application in region \'amer\''))
   })
 
+  test('should show verbose output without region when no region configured', async () => {
+    const config = createDatabaseConfig()
+    const flags = { verbose: true }
+
+    const { spinner } = await runProvisionTest(config, flags)
+
+    expect(spinner.info).toHaveBeenCalledWith(expect.stringContaining('Running: aio app db provision --yes'))
+    expect(spinner.start).toHaveBeenCalledTimes(2) // Once initially, once after verbose info
+    expect(spinner.succeed).toHaveBeenCalledWith(expect.stringContaining('Deployed database for application'))
+  })
+
   test('should handle provision command failure', async () => {
     const config = createDatabaseConfig('amer')
     const flags = { verbose: false }