Skip to content

Commit f495c4e

Browse files
authored
fix: remove node-abort-controller polyfill, breaking Node 24 compatibility (#927)
Node 24 tightened validation in events.setMaxListeners() to require true EventEmitter/EventTarget instances. The node-abort-controller polyfill's AbortSignal is a plain object, causing ERR_INVALID_ARG_TYPE crashes during aio app init. The polyfill was added for Node <=16.13 compat and is no longer needed since engines.node is >=20. Fixes ACNA-4621
1 parent e3c1683 commit f495c4e

2 files changed

Lines changed: 0 additions & 4 deletions

File tree

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
"js-yaml": "^4.1.0",
3939
"junk": "^3.1.0",
4040
"lodash.clonedeep": "^4.5.0",
41-
"node-abort-controller": "^3.1.1",
4241
"open": "^8.4.2",
4342
"ora": "^5",
4443
"pure-http": "^3",

src/BaseCommand.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ OF ANY KIND, either express or implied. See the License for the specific languag
1010
governing permissions and limitations under the License.
1111
*/
1212

13-
const { AbortController } = require('node-abort-controller')
14-
global.AbortController = AbortController
15-
1613
const { Command, Flags } = require('@oclif/core')
1714
const chalk = require('chalk')
1815
const coreConfig = require('@adobe/aio-lib-core-config')

0 commit comments

Comments
 (0)