fix: aio app deploy fails when packages: {} is declared (#233)

* fix: skip dist check and guard ow.package when packages is empty

When a manifest declares `packages: {}` the build step produces no
output so the dist directory is never created. The existing dist check
was throwing "missing files in dist/…, maybe you forgot to build your
actions?" even though there was nothing to build.

* deploy-actions.js: gate the dist check on `hasAnyActions` — only
  validate the build directory when at least one package actually
  defines actions. Two tests cover both branches of `pkg.actions || {}`
  (empty packages and package with no actions key), keeping 100%
  branch coverage on deploy-actions.js.
* utils.js (replacePackagePlaceHolder): guard the `packageNames[0]`
  assignment so an empty packages object no longer clobbers `ow.package`
  with `undefined`.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: warn when packages is empty instead of silently deploying a no-op

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* remove em dash

* fix: throw missing-files error when build dir exists but is empty

The dist-existence check had an operator-precedence bug:
`!fs.readdirSync(dist).length === 0` parses as `(!length) === 0`,
which is always false, so the empty-build-directory branch never
fired. Correct it to `fs.readdirSync(dist).length === 0` so a dist
directory that exists but contains no built actions now raises the
"missing files" error as intended. Adds a test covering that branch.

* fix: skip deploy as a no-op when no packages are declared

When the manifest declares `packages: {}` (e.g. only to trigger database
auto-provisioning), deployActions previously fell through to a full sync
against an empty manifest, which undeploys every previously-deployed
entity for the project. Return early instead so an empty manifest is a
true no-op that leaves existing entities untouched. `aio app undeploy`
remains the explicit way to remove everything.

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Patrick Russell <parussel@adobe.com>

Author: 3 people

src/deploy-actions.js

@@ -57,11 +57,24 @@ async function deployActions (config, deployConfig = {}, logFunc) {
   // checks
   // a. missing credentials
   utils.checkOpenWhiskCredentials(config)
-  // b. missing build files
+  // b. no packages declared (e.g. `packages: {}`, used only to trigger database
+  // auto-provisioning). Skip deployment entirely. Proceeding would run a full
+  // sync against an empty manifest, undeploying every previously-deployed entity
+  // for the project. Use `aio app undeploy` to intentionally remove all entities.
+  const packages = config.manifest.full.packages
+  if (Object.keys(packages).length === 0) {
+    log('Warning: no packages defined in the manifest, skipping deployment. Existing deployed entities are left untouched; use \'aio app undeploy\' to remove them.')
+    return {}
+  }
+
+  // c. missing build files — only required when at least one package defines actions
   const dist = config.actions.dist
+  const hasAnyActions = Object.values(packages)
+    .some(pkg => Object.keys(pkg.actions || {}).length > 0)
   if (
+    hasAnyActions &&
     (!deployConfig.filterEntities || deployConfig.filterEntities.actions) &&
-    (!fs.pathExistsSync(dist) || !fs.lstatSync(dist).isDirectory() || !fs.readdirSync(dist).length === 0)
+    (!fs.pathExistsSync(dist) || !fs.lstatSync(dist).isDirectory() || fs.readdirSync(dist).length === 0)
   ) {
     throw new Error(`missing files in ${utils._relApp(config.root, dist)}, maybe you forgot to build your actions ?`)
   }

src/utils.js

@@ -2104,7 +2104,9 @@ function replacePackagePlaceHolder (config) {
     // Using custom package name.
     // Set config.ow.package so that syncProject can use it as project name for annotations.
     const packageNames = Object.keys(packages)
-    modifiedConfig.ow.package = packageNames[0]
+    if (packageNames.length > 0) {
+      modifiedConfig.ow.package = packageNames[0]
+    }
   }
   return modifiedConfig
 }

test/deploy.actions.test.js

@@ -577,12 +577,30 @@ test('Deploy actions should fail if there are no build files and action filter',
     .rejects.toThrow('missing files in dist')
 })
 
+test('Deploy actions should fail if the build directory exists but is empty', async () => {
+  addSampleAppFiles()
+  // dist exists as a directory but contains no built actions
+  global.fakeFileSystem.addJson({ [global.sampleAppConfig.actions.dist]: null })
+  await expect(deployActions(global.sampleAppConfig))
+    .rejects.toThrow('missing files in dist')
+})
+
 test('Deploy actions should pass if there are no build files and filter does not include actions', async () => {
   addSampleAppFiles()
   runtimeLibUtils.processPackage.mockReturnValue({})
   await expect(deployActions(global.sampleAppConfig, { filterEntities: { triggers: ['trigger1'] } })).resolves.toEqual({})
 })
 
+test('Deploy actions should be a no-op (no undeploy) and warn when packages: {} (empty packages)', async () => {
+  const emptyPackagesConfig = deepCopy(global.sampleAppConfig)
+  emptyPackagesConfig.manifest.full.packages = {}
+  const logSpy = jest.fn()
+  await expect(deployActions(emptyPackagesConfig, {}, logSpy)).resolves.toEqual({})
+  expect(logSpy).toHaveBeenCalledWith(expect.stringContaining('no packages defined'))
+  // must not run a full sync that would undeploy previously-deployed entities
+  expect(runtimeLibUtils.syncProject).not.toHaveBeenCalled()
+})
+
 // lonely
 test('if actions are deployed and part of the manifest it should return their url', async () => {
   addSampleAppReducedFiles()

test/utils.test.js

@@ -3097,3 +3097,43 @@ describe('loadIMSCredentialsFromEnv', () => {
     expect(result.scopes).toBe('not json')
   })
 })
+
+describe('replacePackagePlaceHolder', () => {
+  test('leaves ow.package unchanged when packages is empty (packages: {})', () => {
+    const config = {
+      ow: { package: 'my-pkg' },
+      manifest: {
+        packagePlaceholder: '__APP_PACKAGE__',
+        full: { packages: {} }
+      }
+    }
+    const result = utils.replacePackagePlaceHolder(config)
+    expect(result.ow.package).toBe('my-pkg')
+  })
+
+  test('renames placeholder package to ow.package', () => {
+    const config = {
+      ow: { package: 'my-pkg' },
+      manifest: {
+        packagePlaceholder: '__APP_PACKAGE__',
+        full: { packages: { __APP_PACKAGE__: { actions: {} } } }
+      }
+    }
+    const result = utils.replacePackagePlaceHolder(config)
+    expect(result.ow.package).toBe('my-pkg')
+    expect(result.manifest.full.packages['my-pkg']).toBeDefined()
+    expect(result.manifest.full.packages.__APP_PACKAGE__).toBeUndefined()
+  })
+
+  test('sets ow.package to first package name when no placeholder matches', () => {
+    const config = {
+      ow: { package: 'ignored' },
+      manifest: {
+        packagePlaceholder: '__APP_PACKAGE__',
+        full: { packages: { 'custom-pkg': { actions: {} } } }
+      }
+    }
+    const result = utils.replacePackagePlaceHolder(config)
+    expect(result.ow.package).toBe('custom-pkg')
+  })
+})