ISSUE-43 : Add DEBUG logging for GraphQL Client Cache HIT/MISS or Exc…#44
Open
sagarsane wants to merge 1 commit into
Open
ISSUE-43 : Add DEBUG logging for GraphQL Client Cache HIT/MISS or Exc…#44sagarsane wants to merge 1 commit into
sagarsane wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
thanks much for this, will help triage miss(ed) cache hits and other cache weirdness |
LSantha
reviewed
Feb 2, 2024
| CacheKey key = new CacheKey(request, options); | ||
| try { | ||
| LOGGER.debug("Cache HIT : Returning response from cache for key {}", key); | ||
| return (GraphqlResponse<T, U>) cache.get(key, () -> executeImpl(request, typeOfT, typeofU, options)); |
Collaborator
There was a problem hiding this comment.
Please pay attention to the fact that when 'cache' does don't have an entry for 'key' then it will execute the provided function in the second parameter of get() and if there's a valid response it will update the cache.
So your current approach is logging incorrectly both the cache hits and the cache misses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added DEBUG and ERROR logs when there is a Cache HIT or MISS or in case of an exception.
Description
Related Issue
Related Issue: #43
Motivation and Context
To be able to investigate issues when GraphQL Client Cache Configuration is missing or has errors. Especially on AEM 6.5.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: