Skip to content

ISSUE-43 : Add DEBUG logging for GraphQL Client Cache HIT/MISS or Exc… #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sagarsane wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ISSUE-43 : Add DEBUG logging for GraphQL Client Cache HIT/MISS or Exc… #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/com/adobe/cq/commerce/graphql/client/impl/GraphqlClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,11 +282,14 @@ public <T, U> GraphqlResponse<T, U> execute(GraphqlRequest request, Type typeOfT
if (cache != null) {
CacheKey key = new CacheKey(request, options);
try {
LOGGER.debug("Cache HIT : Returning response from cache for key {}", key);
return (GraphqlResponse<T, U>) cache.get(key, () -> executeImpl(request, typeOfT, typeofU, options));
Copy link
Copy Markdown
Collaborator

@LSantha LSantha Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pay attention to the fact that when 'cache' does don't have an entry for 'key' then it will execute the provided function in the second parameter of get() and if there's a valid response it will update the cache.
So your current approach is logging incorrectly both the cache hits and the cache misses.

} catch (ExecutionException e) {
LOGGER.error("Failed to return response from Cache", e);
return null;
}
}
LOGGER.debug("Cache MISS : Executing GraphQL call with Commerce");
return executeImpl(request, typeOfT, typeofU, options);
}

Expand Down