Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
|
I guess the Fix URL is wrong. Should it be https://hlx6img--da-live--adobe.aem.live/media#/rofe/da-hlx6/firefly-gemini-flash-shy-pandamouse-drinkin-water-from-a-pond-922205.png ? |
|
Just a thought, instead of using blob urls, you could add the Helix 6 source API to the preview proxy as a place to retrieve images from and then rewrite the media block source to use the preview proxy, just like it is going to work in the editor via #930 . That way, you have unified the access to images inside DA.live through the cookie based approach of the Preview Proxy. It is not super clear to me if images uploaded in Helix 6 media bus are immediately available of |
Stupid question: why we don't do it the other way around and do not use a proxy in the editor... ? |
Blob URLs cannot be sent over to iframes. That is why we came up with the preview proxy solition, where the IMS token is set as a |
For hlx6 repos, images/videos are served through api.aem.live with Bearer auth. The previous code used content.da.live which does not serve hlx6 content. Now mirrors the approach from PR #930: detects hlx6 via isHlx6, rewrites contentUrl to the preview.da.live equivalent (same host pattern used for AEM images in the editor), and authenticates with livePreviewLogin instead of contentLogin. No binary fetch or blob URL needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
ok, changed the implementation to go to the preview proxy. Next issue: I assume the preview proxy is not hlx6 ready... I get a 404 for the image. |
that's because the image lives in the source bus until it's previewed (like a plain image in sharepoint lives in sharepoint). i.e. for now, the previous solution with the content url was better. |
|
@tripodsan: The preview proxy can fetch it from there https://api.aem.live/rofe/sites/da-hlx6/source/firefly-gemini-flash-shy-pandamouse-drinkin-water-from-a-pond-922205.png and return it, just like it returned it before from So it is a matter of starting to add support for Helix 6 inside of the preview proxy, if you'd like individually for images with a |
... |
The document editor is just 1 of the ways to visualise or edit the content and the only one that works directly on the native document view that is stored in source bus, without the need to do a full page rendering. There are at least 3 views: (Live Preview, Quick Edit, Universal Editor) which either help visualise or actually edit on top of the un-previewed rendered page, the WYSIWG functionality. The preview proxy is the one providing the underlining "show me the rendered page, while still keeping my content un-previewed". So it needs to understand where to get the unpreviewed content even for Helix 6 scenarios. Having the cookie being set on And these are just the built-in DA functionality. External systems (like for example our Governance Agent) also want to see the rendered page for auditing purposes (e.g. create a screenshot). |
The proxy would need to make the ping request to determine if this is an hlx6 project. Or we need to set it in the client side code "somewhere" (cookie ?) |
The ping would be 1 option. The other would be skipping the ping and just try to load from hlx6, if it isn't there, fallback to admin.da.live. Either way, there will be 2 requests. Could even be started in parallel and then just do the fallback mechanism on the responses. (this would be a little bit wasteful for the case of hlx6 which for the moment will be less dominant, but faster for the fallback case) |
|
I created adobe/da-universal#242. |
Summary
da-hlx6) loadedhttps://content.da.live/…which returns 404 for hlx6 content — images were brokenapi.aem.liveand requires Bearer auth, not the cookie-based flowcontent.da.liveusesisHlx6(owner, repo), fetches the binary throughsource.get()(which handles Bearer auth), and replacescontentUrlwith ablob:URL before passing it to<da-media>loadPdfMedia)contentLogin+content.da.liveURL)Test plan
Problem: https://da.live/media#/rofe/da-hlx6/firefly-gemini-flash-shy-pandamouse-drinkin-water-from-a-pond-922205.png
Fix: http://hlx6img--da-live--adobe.aem.live/media#/rofe/da-hlx6/firefly-gemini-flash-shy-pandamouse-drinkin-water-from-a-pond-922205.png
content.da.liveURL,pathDetailscache object not mutated🤖 Generated with Claude Code