feat(ew): move chat's AI disclaimer outside its bordered body#1076
Open
magdalenaorlowska wants to merge 1 commit into
Open
feat(ew): move chat's AI disclaimer outside its bordered body#1076magdalenaorlowska wants to merge 1 commit into
magdalenaorlowska wants to merge 1 commit into
Conversation
Sets `chat.styled = true` on the nx-chat element created for the canvas chat panel, opting into nx-chat's self-styled mode. No other change is needed here — the surrounding panel automatically drops its own background/border once it contains a self-styled element.
| await import(`${getNx()}/blocks/chat/chat.js`); | ||
| return document.createElement('nx-chat'); | ||
| const chat = document.createElement('nx-chat'); | ||
| chat.styled = true; |
Member
There was a problem hiding this comment.
this reads oddly, styled = true doesn't say what it does. the nx-chat prop is a boolean, can we rename it to something like isPanel on the nx side and set chat.isPanel = true here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sets
chat.styled = trueon the nx-chat element created for the canvas chat panel, opting into nx-chat's self-styled mode. No other change is needed here — the surrounding panel automatically drops its own background/border once it contains a self-styled element.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: