fix: strikethrough support in the importer#392
Merged
chrischrischris merged 2 commits intomainfrom May 5, 2026
Merged
Conversation
hannessolo
reviewed
May 4, 2026
| // convert to mdast | ||
| const mdast = unified() | ||
| .use(remarkParse) | ||
| .use(remarkGfmNoLink) |
Contributor
There was a problem hiding this comment.
It looks like this also supports other things that we don't (like foot notes or checklists) - do they use the same plugin in the helix pipeline, and how do they prevent parsing that stuff? Not sure if necessary, it would get stripped out further along anyway.
Contributor
Author
There was a problem hiding this comment.
From what I can tell the helix team uses it as is:
https://github.com/adobe/helix-html-pipeline/blob/main/src/steps/parse-markdown.js#L30
https://github.com/search?q=org%3Aadobe%20remarkGfmNoLink&type=code
hannessolo
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #178
Imports
remarkGfmNoLinkfrom@adobe/helix-markdown-supportfor strikethrough supportAlso adds tests for mdToDocDom