fix(ci): add PR build/test gate and repair all tsc -b + lint failures (#115)

* fix(ci): add PR build/test gate and repair all tsc -b + lint failures

The repo had no pull_request CI workflow and main had no branch protection,
so PR #114 merged green while `tsc -b` and lint were red. This adds a CI gate
and fixes every pre-existing and new failure so the gate is green.

Type errors (tsc -b, the real check — bare `tsc --noEmit` is a no-op here
because tsconfig.json only has `references`):
- database.index.test.ts: ordered-select routing tests referenced where/order
  columns not in `include`, and a `seed` helper typed `db` as the empty
  Database; both fixed.
- TransactionResult.changedComponents: Set<keyof C | string> -> Set<string>.
  Component names are always strings; the `keyof C` only widened to
  string|number|symbol for generic C, breaking the type-erased
  TransactionResult<unknown> boundary the reconciler/strategy is written
  against. Cleared the producer-side `as keyof C` workaround casts.
- reconciling applier: store entries as ReconcilingEntry<any,any,any> (the
  layer is type-erased over getTransaction's any-ctx transactions).
- create-store.test.ts: guard optional `.health?.current`.

Lint:
- create-database.test.ts: describe each @ts-expect-error directive.
- test-setup.ts: import { webcrypto } instead of require().

CI / tooling:
- .github/workflows/ci.yml: typecheck + lint + test on every PR and push to
  main, scoped to @adobe/data (where the regression class occurred).
- packages/data: add `typecheck` (build wasm + tsc -b, correct for the
  project-reference build) and `test:ci` (SKIP_PERF=1) scripts.
- vite.config.js / vitest.workspace.ts: exclude *.performance.test.ts when
  SKIP_PERF=1 so the gate is deterministic (timing-ratio perf tests are flaky
  on shared runners); a normal `pnpm test` still runs them.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test(ci): RED probe — deliberate type error to verify gate blocks merge

Intentionally broken; reverted in the next commit.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* Revert CI probe — restore green state

Removes the deliberate type error from the previous commit; the gate is
verified to block on red.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* ci: bump actions to v6 (Node 24 runtime) and node-version to 22

Clears the Node.js 20 action-runtime deprecation warning. checkout, setup-node,
and pnpm/action-setup -> v6; project runtime node-version 20 -> 22 (LTS).
Applied to both ci.yml and deploy-docs.yml.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: krisnye

.github/workflows/ci.yml

@@ -0,0 +1,51 @@
+name: CI
+
+# Validates every pull request (and pushes to main) before merge. Prior to
+# this workflow the only GitHub Action was the post-merge docs deploy, so a PR
+# whose `tsc -b` / unit tests were red could still be merged green — exactly
+# what happened with #114. This gate makes those failures block the merge.
+#
+# Scope: the published core library `@adobe/data`, where the regression class
+# occurred. Type-checking uses the project-reference build (`tsc -b`, via the
+# package's `typecheck` script, which builds the wasm artifact the source
+# imports first). Tests run with SKIP_PERF=1 (`test:ci`) so the gate excludes
+# the non-deterministic timing-ratio perf tests and stays reliable.
+
+on:
+  pull_request:
+  push:
+    branches: [main]
+
+permissions:
+  contents: read
+
+concurrency:
+  group: ci-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  data:
+    name: "@adobe/data — typecheck, lint, test"
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+
+      - uses: pnpm/action-setup@v6
+        with:
+          version: 9
+
+      - uses: actions/setup-node@v6
+        with:
+          node-version: 22
+          cache: pnpm
+
+      - run: pnpm install --frozen-lockfile
+
+      - name: Type-check (tsc -b, project references)
+        run: pnpm --filter @adobe/data run typecheck
+
+      - name: Lint
+        run: pnpm --filter @adobe/data run lint
+
+      - name: Unit tests
+        run: pnpm --filter @adobe/data run test:ci

.github/workflows/deploy-docs.yml

@@ -18,15 +18,15 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
 
-      - uses: pnpm/action-setup@v4
+      - uses: pnpm/action-setup@v6
         with:
           version: 9
 
-      - uses: actions/setup-node@v4
+      - uses: actions/setup-node@v6
         with:
-          node-version: 20
+          node-version: 22
           cache: pnpm
 
       - run: pnpm install --frozen-lockfile

packages/data/package.json

@@ -20,6 +20,7 @@
     "build": "pnpm build-assembly && run-p build:*",
     "build:code": "tsc -b",
     "build:apidocs": "typedoc",
+    "typecheck": "pnpm build-assembly && tsc -b",
     "build-assembly": "run-p asbuild:release",
     "clean": "rm -rf dist build node_modules",
     "clean-cache": "rm -rf node_modules/.cache",
@@ -38,6 +39,7 @@
     "publish-public": "pnpm build && pnpm publish --no-git-checks --access public",
     "perftest": "node dist/perftest/index.js",
     "test": "vitest --run",
+    "test:ci": "SKIP_PERF=1 vitest --run",
     "asbuild:debug": "asc assembly/index.ts -o dist/assembly/index.wasm --target debug --enable simd && echo built dist/assembly/index.wasm",
     "asbuild:release": "asc assembly/index.ts -o dist/assembly/index.wasm --target release --enable simd --optimize && echo built dist/assembly/index.wasm",
     "start": "npx serve ."

packages/data/src/ecs/database/database.index.test.ts

@@ -1010,7 +1010,7 @@ describe("auto-routing of ordered select through a sorted index", () => {
         return { state, restore: () => { handle.find = original; } };
     };
 
-    const seed = (db: ReturnType<typeof Database.create>) => {
+    const seed = (db: Database.FromPlugin<ReturnType<typeof plugin>>) => {
         const mid = db.transactions.add({ owner: 1, priority: 2, due: 10, title: "mid" });
         const low = db.transactions.add({ owner: 1, priority: 1, due: 20, title: "low" });
         const high = db.transactions.add({ owner: 1, priority: 3, due: 30, title: "high" });
@@ -1024,7 +1024,7 @@ describe("auto-routing of ordered select through a sorted index", () => {
 
         const sorted = spyFind((db.indexes as any).byOwnerSorted);
         try {
-            const result = db.select(["title"], { where: { owner: 1 }, order: { priority: true } });
+            const result = db.select(["owner", "priority"], { where: { owner: 1 }, order: { priority: true } });
             // GREEN: the ordered query was served by the sorted index...
             expect(sorted.state.calls).toBe(1);
             // ...and the result is in the index's ascending priority order.
@@ -1041,7 +1041,7 @@ describe("auto-routing of ordered select through a sorted index", () => {
         const unsorted = spyFind((db.indexes as any).byOwner);
         const sorted = spyFind((db.indexes as any).byOwnerSorted);
         try {
-            db.select(["title"], { where: { owner: 1 }, order: { priority: true } });
+            db.select(["owner", "priority"], { where: { owner: 1 }, order: { priority: true } });
             expect(sorted.state.calls).toBe(1);
             expect(unsorted.state.calls).toBe(0);
         } finally {
@@ -1056,7 +1056,7 @@ describe("auto-routing of ordered select through a sorted index", () => {
 
         const sorted = spyFind((db.indexes as any).byOwnerSorted);
         try {
-            const result = db.select(["title"], { where: { owner: 1 }, order: { priority: false } });
+            const result = db.select(["owner", "priority"], { where: { owner: 1 }, order: { priority: false } });
             // Not routed — the index can't serve descending without re-sorting.
             expect(sorted.state.calls).toBe(0);
             // The scan still produces a correct descending result.
@@ -1073,7 +1073,7 @@ describe("auto-routing of ordered select through a sorted index", () => {
         const sorted = spyFind((db.indexes as any).byOwnerSorted);
         try {
             // Index sorts by `priority`; this asks for `due`.
-            const result = db.select(["title"], { where: { owner: 1 }, order: { due: true } });
+            const result = db.select(["owner", "due"], { where: { owner: 1 }, order: { due: true } });
             expect(sorted.state.calls).toBe(0);
             expect(result).toHaveLength(3);
         } finally {
@@ -1088,7 +1088,7 @@ describe("auto-routing of ordered select through a sorted index", () => {
         // No order: the first matching key index (byOwner) serves it.
         const unsorted = spyFind((db.indexes as any).byOwner);
         try {
-            const result = db.select(["title"], { where: { owner: 1 } });
+            const result = db.select(["owner"], { where: { owner: 1 } });
             expect(unsorted.state.calls).toBe(1);
             expect(result).toHaveLength(3);
         } finally {
@@ -1103,7 +1103,7 @@ describe("auto-routing of ordered select through a sorted index", () => {
         const sorted = spyFind((db.indexes as any).byOwnerSorted);
         try {
             const emissions: number[][] = [];
-            const unsub = db.observe.select(["title"], { where: { owner: 1 }, order: { priority: true } })(
+            const unsub = db.observe.select(["owner", "priority"], { where: { owner: 1 }, order: { priority: true } })(
                 (entities) => { emissions.push([...entities]); },
             );
             // Initial snapshot routed and sorted.

packages/data/src/ecs/database/public/create-database.test.ts

@@ -1305,15 +1305,15 @@ describe("createDatabase", () => {
                 });
 
                 // Wrong value type: token should be string, not number
-                // @ts-expect-error
+                // @ts-expect-error token must be a string
                 Database.create(plugin, { services: { auth: { token: 123, isAuthenticated: false } } });
 
                 // Unknown service key
-                // @ts-expect-error
+                // @ts-expect-error nonexistent is not a declared service
                 Database.create(plugin, { services: { nonexistent: { foo: 'bar' } } });
 
                 // Missing required property (isAuthenticated)
-                // @ts-expect-error
+                // @ts-expect-error auth override is missing isAuthenticated
                 Database.create(plugin, { services: { auth: { token: 'x' } } });
             });
         });

packages/data/src/ecs/database/reconciling/create-rebase-replay-applier.ts

@@ -32,7 +32,12 @@ export function createRebaseReplayApplier(
     replayAllTransients: () => TransactionResult<unknown> | undefined;
 } {
     const [execute, getTransaction] = args;
-    const reconcilingEntries: ReconcilingEntry[] = [];
+    // The applier is a type-erased layer: `getTransaction` hands back
+    // transactions typed over `TransactionContext<any, any, any>`, so the
+    // entries it stores are erased too. Pinning the generics to `any` keeps the
+    // stored `transaction` assignable from `getTransaction`'s result without a
+    // per-assignment cast.
+    const reconcilingEntries: ReconcilingEntry<any, any, any>[] = [];
 
     const rollbackEntryResult = (entry: ReconcilingEntry) => {
         if (entry.result) {
@@ -90,7 +95,7 @@ export function createRebaseReplayApplier(
             rollbackAllTransients();
             spliceTransientEntry(id, userId);
 
-            const entry: ReconcilingEntry = {
+            const entry: ReconcilingEntry<any, any, any> = {
                 id,
                 userId,
                 name: envelope.name,

packages/data/src/ecs/database/transactional-store/create-transactional-store.ts

@@ -39,7 +39,7 @@ export function createTransactionalStore<
     };
     const changed = {
         entities: new Map<Entity, EntityUpdateValues<C> | null>(),
-        components: new Set<keyof C>(),
+        components: new Set<string>(),
         archetypes: new Set<ArchetypeId>(),
     };
 
@@ -62,7 +62,7 @@ export function createTransactionalStore<
                 changed.entities.set(entity, values);
                 changed.archetypes.add(id);
                 for (const key in values) {
-                    changed.components.add(key as never);
+                    changed.components.add(key);
                 }
                 return entity;
             },
@@ -98,7 +98,7 @@ export function createTransactionalStore<
                     oldValue = DELETE;
                 }
                 replacedValues[name] = oldValue;
-                changed.components.add(name as keyof C);
+                changed.components.add(name);
             }
         }
 
@@ -136,7 +136,7 @@ export function createTransactionalStore<
 
         const { id: _ignore, ...oldValuesWithoutId } = oldValues as any;
         for (const key in oldValuesWithoutId) {
-            changed.components.add(key as keyof C);
+            changed.components.add(key);
         }
 
         store.delete(entity);

packages/data/src/ecs/database/transactional-store/transactional-store.ts

@@ -96,6 +96,11 @@ export interface TransactionResult<C = unknown> {
     readonly redo: TransactionWriteOperation<C>[];
     readonly undo: TransactionWriteOperation<C>[];
     readonly changedEntities: Map<Entity, EntityUpdateValues<C> | null>;
-    readonly changedComponents: Set<keyof C | string>;
+    // Component names are always strings. Keeping this `Set<string>` (rather
+    // than `Set<keyof C | string>`) avoids widening to `string | number |
+    // symbol` for a generic `C`, which otherwise makes `TransactionResult<C>`
+    // fail to satisfy the type-erased `TransactionResult<unknown>` boundary the
+    // concurrency strategy / reconciler is written against.
+    readonly changedComponents: Set<string>;
     readonly changedArchetypes: Set<ArchetypeId>;
 }

packages/data/src/ecs/store/public/create-store.test.ts

@@ -630,7 +630,7 @@ describe("createStore", () => {
                 const fresh = createStore({ components: { health: healthSchema }, resources: {}, archetypes: {} });
                 fresh.fromData(snapshot);
                 const restored = fresh.select(["health"]);
-                return fresh.read(restored[0])?.health.current;
+                return fresh.read(restored[0])?.health?.current;
             };
 
             // Detached: mutating after the snapshot must NOT change it.

packages/data/src/test-setup.ts

@@ -1,5 +1,7 @@
 // © 2026 Adobe. MIT License. See /LICENSE for details.
 
+import { webcrypto } from "node:crypto";
+
 // Polyfills for Node 18 test environment
 
 // window polyfill (minimal — only what the source files actually use)
@@ -58,7 +60,7 @@ if (typeof globalThis.caches === "undefined") {
 
 // Web Crypto API: Node 18 has globalThis.crypto but not the bare `crypto` name in all contexts
 if (typeof (globalThis as any).crypto === "undefined") {
-  (globalThis as any).crypto = require("node:crypto").webcrypto;
+  (globalThis as any).crypto = webcrypto;
 }
 
 // requestAnimationFrame polyfill for Node