Skip to content
This repository was archived by the owner on Aug 28, 2023. It is now read-only.

Commit 6de7ca0

Browse files
authored
Update constant name (#9)
* Update constant name * Update constant value
1 parent f80c6e5 commit 6de7ca0

6 files changed

Lines changed: 11 additions & 11 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ tracker.trackError("errorId");
183183
##### trackEvent:
184184
```javascript
185185
let adBreakObject = ACPMedia.createAdBreakObject("adbreak-name", 1, 0);
186-
tracker.trackEvent(ACPMediaEvent.AdBreakStart, adBreakObject, null);
186+
tracker.trackEvent(ACPMediaEvent.EventAdBreakStart, adBreakObject, null);
187187
```
188188

189189
##### updateCurrentPlayhead:
@@ -288,7 +288,7 @@ This defines the type of a tracking event.
288288
```javascript
289289
import {ACPMediaEvent} from '@adobe/react-native-acpmedia';
290290

291-
ACPMediaEvent.AdBreakStart
291+
ACPMediaEvent.EventAdBreakStart
292292
ACPMediaEvent.EventAdBreakComplete
293293
ACPMediaEvent.EventAdStart
294294
ACPMediaEvent.EventAdComplete

__tests__/ACPMediaTrackerTests.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ describe('ACPMediaTracker', () => {
9191
let data = {"testKey": "testVal"};
9292

9393
const spy = jest.spyOn(NativeModules.ACPMedia, 'trackEvent');
94-
tracker.trackEvent(ACPMediaEvent.AdBreakStart, adBreakObject, data);
95-
expect(spy).toHaveBeenCalledWith(tracker.trackerId, ACPMediaEvent.AdBreakStart, adBreakObject, data);
94+
tracker.trackEvent(ACPMediaEvent.EventAdBreakStart, adBreakObject, data);
95+
expect(spy).toHaveBeenCalledWith(tracker.trackerId, ACPMediaEvent.EventAdBreakStart, adBreakObject, data);
9696
});
9797

9898
test('updateCurrentPlayhead is called with correct parameters', async () => {

android/src/main/java/com/adobe/marketing/mobile/reactnative/media/RCTACPMediaDataBridge.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import com.adobe.marketing.mobile.Media.Event;
1616

1717
public class RCTACPMediaDataBridge {
18-
private static final String EventAdBreakStart = "AdBreakStart";
18+
private static final String EventAdBreakStart = "EventAdBreakStart";
1919
private static final String EventAdBreakComplete = "EventAdBreakComplete";
2020
private static final String EventAdStart = "EventAdStart";
2121
private static final String EventAdComplete = "EventAdComplete";

ios/src/ACPMedia+ACPMediaEventConversion.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
@implementation ACPMedia (ACPMediaEventConversion)
1515

16-
static NSString* const AdBreakStart = @"AdBreakStart";
16+
static NSString* const AdBreakStart = @"EventAdBreakStart";
1717
static NSString* const EventAdBreakComplete = @"EventAdBreakComplete";
1818
static NSString* const EventAdStart = @"EventAdStart";
1919
static NSString* const EventAdComplete = @"EventAdComplete";
@@ -55,7 +55,7 @@ + (ACPMediaEvent)mediaEventFromString:(NSString *)eventString {
5555
} else if ([eventString isEqualToString:EventBitrateChange]) {
5656
return ACPMediaEventBitrateChange;
5757
}
58-
58+
5959
return ACPMediaEventAdBreakStart;
6060
}
6161

js/models/ACPMediaEvent.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ governing permissions and limitations under the License.
1313

1414
'use strict';
1515

16-
const AdBreakStart = "AdBreakStart";
16+
const EventAdBreakStart = "EventAdBreakStart";
1717
const EventAdBreakComplete = "EventAdBreakComplete";
1818
const EventAdStart = "EventAdStart";
1919
const EventAdComplete = "EventAdComplete";
@@ -30,8 +30,8 @@ const EventBitrateChange = "EventBitrateChange";
3030

3131
class ACPMediaEvent {
3232

33-
static get AdBreakStart() {
34-
return AdBreakStart;
33+
static get EventAdBreakStart() {
34+
return EventAdBreakStart;
3535
}
3636

3737
static get EventAdBreakComplete() {

sample/ACPMediaSample/App.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ export default class App extends Component<Props> {
110110

111111
trackEvent() {
112112
let adBreakObject = ACPMedia.createAdBreakObject("adbreak-name", 1, 0);
113-
this.state.currentTracker.trackEvent(ACPMediaEvent.AdBreakStart, adBreakObject, null);
113+
this.state.currentTracker.trackEvent(ACPMediaEvent.EventAdBreakStart, adBreakObject, null);
114114
}
115115

116116
updateCurrentPlayhead() {

0 commit comments

Comments
 (0)