Merge branch 'main' into dnd-highlight-nice-to-have

Author: yihuiliao

.chromatic-fc/custom-addons/chromatic/disableAnimations.css

@@ -1,3 +1,16 @@
 .disableAnimations * {
   transition: none !important;
+  animation: none !important;
+}
+
+/*
+  Overlays that use useEnterAnimation/useExitAnimation (Popover, Tooltip, Tabs)
+  render at a translate offset while [data-entering]/[data-exiting] is true,
+  relying on the transition to slide back to translate: 0. With transitions
+  disabled in Chromatic, the slide never happens, so a snapshot taken while
+  isEntering is still true catches the popover ~4px off.
+*/
+.disableAnimations [data-entering],
+.disableAnimations [data-exiting] {
+  translate: none !important;
 }

.chromatic-fc/preview-head.html

@@ -187,6 +187,38 @@
   as="font"
   crossorigin="anonymous" />
 
+<!--
+  Noto Sans Ethiopic: Adobe Clean does not cover the Ethiopic script (U+1200-137F),
+  so without an explicit @font-face the browser falls through to a system font
+  whose loading is not tracked by document.fonts.ready. That makes Amharic
+  stories (e.g. DateField > Amharic Preferences) flaky in Chromatic. 
+  Declaring it under font-family: adobe-clean with a unicode-range
+  for Ethiopic extends the adobe-clean family for those code points, and
+  font-display: block ensures Chromatic waits for it before snapshotting.
+  
+  This font is what Chrome falls back to anyways, we're just making sure Chromatic
+  waits for it before snapshotting.
+-->
+<link
+  rel="preload"
+  href="https://fonts.gstatic.com/s/notosansethiopic/v50/7cHPv50vjIepfJVOZZgcpQ5B9FBTH9KGNfhSTgtoow1KVnIvyBoMSzUMacb-T35OK5D1yGb8bJ9vaUNpog.woff2"
+  as="font"
+  type="font/woff2"
+  crossorigin="anonymous" />
+<style>
+  @font-face {
+    font-family: 'adobe-clean';
+    font-style: normal;
+    font-weight: 400;
+    font-display: block;
+    src: url('https://fonts.gstatic.com/s/notosansethiopic/v50/7cHPv50vjIepfJVOZZgcpQ5B9FBTH9KGNfhSTgtoow1KVnIvyBoMSzUMacb-T35OK5D1yGb8bJ9vaUNpog.woff2')
+      format('woff2');
+    unicode-range:
+      U+030E, U+1200-1399, U+2D80-2DDE, U+AB01-AB2E, U+1E7E0-1E7E6, U+1E7E8-1E7EB, U+1E7ED-1E7EE,
+      U+1E7F0-1E7FE;
+  }
+</style>
+
 <!--
   fe1ce2 font: adobe-clean-serif, weight: 900
   f46796 font: adobe-clean-serif, style: italic, weight: 900

.chromatic/custom-addons/chromatic/disableAnimations.css

@@ -1,3 +1,16 @@
 .disableAnimations * {
   transition: none !important;
+  animation: none !important;
+}
+
+/*
+  Overlays that use useEnterAnimation/useExitAnimation (Popover, Tooltip, Tabs)
+  render at a translate offset while [data-entering]/[data-exiting] is true,
+  relying on the transition to slide back to translate: 0. With transitions
+  disabled in Chromatic, the slide never happens, so a snapshot taken while
+  isEntering is still true catches the popover ~4px off.
+*/
+.disableAnimations [data-entering],
+.disableAnimations [data-exiting] {
+  translate: none !important;
 }

.chromatic/preview-head.html

@@ -187,6 +187,38 @@
   as="font"
   crossorigin="anonymous" />
 
+<!--
+  Noto Sans Ethiopic: Adobe Clean does not cover the Ethiopic script (U+1200-137F),
+  so without an explicit @font-face the browser falls through to a system font
+  whose loading is not tracked by document.fonts.ready. That makes Amharic
+  stories (e.g. DateField > Amharic Preferences) flaky in Chromatic. 
+  Declaring it under font-family: adobe-clean with a unicode-range
+  for Ethiopic extends the adobe-clean family for those code points, and
+  font-display: block ensures Chromatic waits for it before snapshotting.
+  
+  This font is what Chrome falls back to anyways, we're just making sure Chromatic
+  waits for it before snapshotting.
+-->
+<link
+  rel="preload"
+  href="https://fonts.gstatic.com/s/notosansethiopic/v50/7cHPv50vjIepfJVOZZgcpQ5B9FBTH9KGNfhSTgtoow1KVnIvyBoMSzUMacb-T35OK5D1yGb8bJ9vaUNpog.woff2"
+  as="font"
+  type="font/woff2"
+  crossorigin="anonymous" />
+<style>
+  @font-face {
+    font-family: 'adobe-clean';
+    font-style: normal;
+    font-weight: 400;
+    font-display: block;
+    src: url('https://fonts.gstatic.com/s/notosansethiopic/v50/7cHPv50vjIepfJVOZZgcpQ5B9FBTH9KGNfhSTgtoow1KVnIvyBoMSzUMacb-T35OK5D1yGb8bJ9vaUNpog.woff2')
+      format('woff2');
+    unicode-range:
+      U+030E, U+1200-1399, U+2D80-2DDE, U+AB01-AB2E, U+1E7E0-1E7E6, U+1E7E8-1E7EB, U+1E7ED-1E7EE,
+      U+1E7F0-1E7FE;
+  }
+</style>
+
 <!--
   fe1ce2 font: adobe-clean-serif, weight: 900
   f46796 font: adobe-clean-serif, style: italic, weight: 900

.circleci/config.yml

@@ -21,30 +21,31 @@ executors:
   rsp:
     docker:
       - image: cimg/node:24.14.1
+    resource_class: medium.gen2
     environment:
       CACHE_VERSION: v1
     working_directory: ~/react-spectrum
 
   rsp-large:
     docker:
       - image: cimg/node:24.14.1
-    resource_class: large
+    resource_class: large.gen2
     environment:
       CACHE_VERSION: v1
     working_directory: ~/react-spectrum
 
   rsp-xlarge:
     docker:
       - image: cimg/node:24.14.1
-    resource_class: xlarge
+    resource_class: xlarge.gen2
     environment:
       CACHE_VERSION: v1
     working_directory: ~/react-spectrum
 
   rsp-2xlarge:
     docker:
       - image: cimg/node:24.14.1
-    resource_class: 2xlarge
+    resource_class: 2xlarge.gen2
     environment:
       CACHE_VERSION: v1
     working_directory: ~/react-spectrum
@@ -447,7 +448,7 @@ jobs:
           name: build fork-point apis
           command: |
             mkdir -p ~/.ssh
-            curl -L https://api.github.com/meta | jq -r '.ssh_keys | .[]' | sed -e 's/^/github.com /' >> ~/.ssh/known_hosts
+            ssh-keyscan -t rsa,ed25519 github.com >> ~/.ssh/known_hosts
             yarn build:api-branch --githash="origin/main" --output="base-api" && yarn build:api-branch && yarn compare:apis
 
       - persist_to_workspace:
@@ -490,7 +491,7 @@ jobs:
           name: build agent skills (main)
           command: |
             mkdir -p ~/.ssh
-            curl -L https://api.github.com/meta | jq -r '.ssh_keys | .[]' | sed -e 's/^/github.com /' >> ~/.ssh/known_hosts
+            ssh-keyscan -t rsa,ed25519 github.com >> ~/.ssh/known_hosts
             BRANCH_ROOT="$(pwd)"
             BUILD_SKILLS="$BRANCH_ROOT/.circleci/build-skills.sh"
             git worktree add --detach /tmp/main-worktree origin/main

.github/labeler.yml

@@ -6,16 +6,20 @@ needs translations:
 
 S2:
   - changed-files:
-      - any-glob-to-any-file: ['**/s2/**']
+      - all-globs-to-any-file: ['**/s2/**', '!**/*.stories.*', '!**/*.test.*']
 
 RAC:
-  - changed-files:
-      - any-glob-to-any-file: ['**/react-aria-components/**', '**/@react-aria/**']
+  - any:
+      - changed-files:
+          - all-globs-to-any-file:
+              ['**/react-aria-components/**', '!**/*.stories.*', '!**/*.test.*']
+      - changed-files:
+          - all-globs-to-any-file: ['**/@react-aria/**', '!**/*.stories.*', '!**/*.test.*']
 
 v3:
   - all:
       - changed-files:
-          - any-glob-to-any-file: '**/@react-spectrum/**'
+          - all-globs-to-any-file: ['**/@react-spectrum/**', '!**/*.stories.*', '!**/*.test.*']
           - all-globs-to-all-files: '!**/@react-spectrum/s2/**'
 
 Accordion:

.github/workflows/weekly-api-diff.yml

@@ -136,7 +136,6 @@ jobs:
         env:
           SLACK_TSDIFF_CHROMATIC_BOT_TOKEN: ${{ secrets.SLACK_TSDIFF_CHROMATIC_BOT_TOKEN }}
           SLACK_CHANNEL_ID: ${{ secrets.SLACK_CHANNEL_ID }}
-          TEST_SLACK_ID: ${{ secrets.TEST_SLACK_ID }}
           GITHUB_TOKEN: ${{ github.token }}
         run: |
           python3 << 'PYEOF'
@@ -165,17 +164,38 @@ jobs:
 
           new_release = os.environ.get('NEW_RELEASE') == 'true'
 
+          def post(text, thread_ts=None):
+            payload = {"channel": channel, "text": text, "unfurl_links": False, "unfurl_media": False}
+            if thread_ts:
+              payload["thread_ts"] = thread_ts
+            req = urllib.request.Request(
+              'https://slack.com/api/chat.postMessage',
+              data=json.dumps(payload).encode(),
+              headers={
+                'Authorization': f'Bearer {slack_token}',
+                'Content-Type': 'application/json'
+              }
+            )
+            resp = json.loads(urllib.request.urlopen(req).read())
+            print("Slack response:", resp.get('ok'), resp.get('error', ''))
+            if not resp.get('ok'):
+              raise SystemExit(f"Slack error: {resp.get('error')}")
+            return resp['message']['ts']
+
           if vs_release_size == 0:
-            message = f"📊 Weekly API Diff — {today}\n\nNo API changes detected vs last release — all pending changes have been included in a release."
+            body = "No API changes detected vs last release — all pending changes have been included in a release."
           elif vs_last_week_size == 0 and not new_release:
             prev_ref = f"last diff ({prev_date}): {prev_url}" if prev_date else "last diff"
-            message = f"📊 Weekly API Diff — {today}\n\nNo new API changes since {prev_ref}."
+            body = f"No new API changes since {prev_ref}."
           elif new_release:
-            message = f"📊 Weekly API Diff — {today}\n\nNew release since last diff — resetting baseline. Full diff vs release: {diff_url}\n\nReact ✅ if changes look expected, or 🚨 if something looks wrong."
+            body = f"New release since last diff — resetting baseline. Full diff vs release: {diff_url}\n\nReact ✅ if changes look expected, or 🚨 if something looks wrong."
           else:
             # Read the already-processed delta saved by the shell step
             delta_path = f"{workspace}/snapshots/deltas/{today}.txt"
-            model_input = open(delta_path).read() if os.path.exists(delta_path) else ""
+            model_input_full = open(delta_path).read() if os.path.exists(delta_path) else ""
+            TRUNCATE_LIMIT = 8000
+            truncated = len(model_input_full) > TRUNCATE_LIMIT
+            model_input = model_input_full[:TRUNCATE_LIMIT] if truncated else model_input_full
 
             # Extract classification rules from prompt.md (single source of truth)
             prompt_md = open(f"{workspace}/scripts/weekly-api-diff/prompt.md").read()
@@ -210,18 +230,9 @@ jobs:
               }
             )
             summary = json.loads(urllib.request.urlopen(req).read())['choices'][0]['message']['content']
-            message = f"📊 Weekly API Diff — {today}\n\n{summary}\n\nWhat's new this week: {delta_url}\nFull diff vs release: {diff_url}\n\nReact ✅ if changes look expected, or 🚨 if something looks wrong."
-
-          req = urllib.request.Request(
-            'https://slack.com/api/chat.postMessage',
-            data=json.dumps({"channel": channel, "text": message}).encode(),
-            headers={
-              'Authorization': f'Bearer {slack_token}',
-              'Content-Type': 'application/json'
-            }
-          )
-          resp = json.loads(urllib.request.urlopen(req).read())
-          print("Slack response:", resp.get('ok'), resp.get('error', ''))
-          if not resp.get('ok'):
-            raise SystemExit(f"Slack error: {resp.get('error')}")
+            truncation_note = "\n\n⚠️ Delta was large — summary may be incomplete. Check the full delta link below." if truncated else ""
+            body = f"{summary}{truncation_note}\n\nWhat's new this week: {delta_url}\nFull diff vs release: {diff_url}\n\nReact ✅ if changes look expected, or 🚨 if something looks wrong."
+
+          ts = post(f"📊 Weekly API Diff — {today}")
+          post(f"📊 Weekly API Diff — {today}\n\n{body}", thread_ts=ts)
           PYEOF

.github/workflows/weekly-chromatic.yml

@@ -93,23 +93,29 @@ jobs:
                   return f"✅ | {url}"
               return f"⚠️ changes pending review | {url}"
 
-          message = "\n".join([
-              f"📸 Weekly Chromatic — {today}",
-              "",
+          body = "\n".join([
               f"Chromatic: {fmt(os.environ['CHROMATIC_CODE'], os.environ['CHROMATIC_URL'])}",
               f"Forced Colors: {fmt(os.environ['CHROMATIC_FC_CODE'], os.environ['CHROMATIC_FC_URL'])}",
           ])
 
-          req = urllib.request.Request(
-              'https://slack.com/api/chat.postMessage',
-              data=json.dumps({"channel": channel, "text": message}).encode(),
-              headers={
-                  'Authorization': f'Bearer {slack_token}',
-                  'Content-Type': 'application/json'
-              }
-          )
-          resp = json.loads(urllib.request.urlopen(req).read())
-          print("Slack response:", resp.get('ok'), resp.get('error', ''))
-          if not resp.get('ok'):
-              raise SystemExit(f"Slack error: {resp.get('error')}")
+          def post(text, thread_ts=None):
+              payload = {"channel": channel, "text": text, "unfurl_links": False, "unfurl_media": False}
+              if thread_ts:
+                  payload["thread_ts"] = thread_ts
+              req = urllib.request.Request(
+                  'https://slack.com/api/chat.postMessage',
+                  data=json.dumps(payload).encode(),
+                  headers={
+                      'Authorization': f'Bearer {slack_token}',
+                      'Content-Type': 'application/json'
+                  }
+              )
+              resp = json.loads(urllib.request.urlopen(req).read())
+              print("Slack response:", resp.get('ok'), resp.get('error', ''))
+              if not resp.get('ok'):
+                  raise SystemExit(f"Slack error: {resp.get('error')}")
+              return resp['message']['ts']
+
+          ts = post(f"📸 Weekly Chromatic — {today}")
+          post(f"📸 Weekly Chromatic — {today}\n\n{body}", thread_ts=ts)
           PYEOF

CONTRIBUTING.md

@@ -48,7 +48,7 @@ Lastly, please follow the pull request template when submitting a pull request!
 All third-party contributions to this project must be accompanied by a signed contributor license agreement. This gives Adobe permission to redistribute your contributions as part of the project. [Sign our CLA](https://opensource.adobe.com/cla.html). You only need to submit an Adobe CLA one time, so if you have submitted one previously, you are good to go!
 
 ## Where to start
-There are many places to dive into react-spectrum to help out. Before you take on a feature or issue, make sure you become familiar with [our architecture](https://react-spectrum.adobe.com/architecture.html).
+There are many places to dive into react-spectrum to help out. Before you take on a feature or issue, make sure you become familiar with [our architecture](https://github.com/adobe/react-spectrum/blob/main/rfcs/2019-v3-architecture.md).
 
 If you are looking for place to start, consider the following options:
 - Look for issues tagged with help wanted and/or good first issue.

README.md

@@ -41,10 +41,10 @@ React Spectrum includes several libraries, which you can choose depending on you
 * [React Aria](https://react-spectrum.adobe.com/react-aria/getting-started.html) is a collection of unstyled React components and hooks that helps you build accessible, high quality UI components for your own application or design system. If you're building a component library for the web from scratch with your own styling, start here.
 * [React Stately](https://react-spectrum.adobe.com/react-stately/getting-started.html) is a library of state management hooks for use in your component library. If you're using React Aria, you'll likely also use React Stately, but it can also be used independently (e.g. on other platforms like React Native).
 
-[Read more about our architecture](https://react-spectrum.adobe.com/architecture.html).
+[Read more about our architecture](https://github.com/adobe/react-spectrum/blob/main/rfcs/2019-v3-architecture.md).
 
 ## Contributing
 
 One of the goals of the React Spectrum project is to make building design systems and component libraries as easy as possible, while maintaining high quality interactions and accessibility support. We aim to raise the bar for web applications. The best way to achieve that goal is **together**. We would love contributions from the community no matter how big or small. 😍
 
-Read our [contributing guide](https://github.com/adobe/react-spectrum/blob/main/CONTRIBUTING.md) to learn about how to propose bugfixes and improvements, and how the development process works. For detailed information about our architecture, and how all of the pieces fit together, read our [architecture docs](https://react-spectrum.adobe.com/architecture.html).
+Read our [contributing guide](https://github.com/adobe/react-spectrum/blob/main/CONTRIBUTING.md) to learn about how to propose bugfixes and improvements, and how the development process works. For detailed information about our architecture, and how all of the pieces fit together, read our [architecture rfc](https://github.com/adobe/react-spectrum/blob/main/rfcs/2019-v3-architecture.md).