error messaging and simplification

Author: LFDanLu

.github/workflows/weekly-api-diff.yml

@@ -14,7 +14,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
         with:
-          fetch-depth: 0  # required for --auto-baseline to find the last Publish commit
+          fetch-depth: 0  # required for build:api-published to find the last Publish commit
 
       - uses: actions/setup-node@v4
         with:
@@ -31,13 +31,8 @@ jobs:
       - name: Build release baseline
         run: yarn build:api-published
 
-      # Generate diff — compareAPIs.js requires absolute paths
       - name: Generate diff
-        run: |
-          yarn compare:apis \
-            --branch-api-dir=$GITHUB_WORKSPACE/dist/branch-api \
-            --base-api-dir=$GITHUB_WORKSPACE/dist/base-api \
-            --isCI > /tmp/diff-current.txt 2>&1 || true
+        run: yarn compare:apis --isCI > /tmp/diff-current.txt 2>&1 || true
 
       # Check out snapshots repo so we can read the previous diff and commit the new one
       - uses: actions/checkout@v4
@@ -78,6 +73,11 @@ jobs:
           python3 << 'PYEOF'
           import json, os, urllib.request, subprocess
 
+          required = ['SLACK_TSDIFF_CHROMATIC_BOT_TOKEN', 'SLACK_CHANNEL_ID', 'GITHUB_TOKEN', 'TODAY', 'SNAPSHOTS_REPO', 'GITHUB_WORKSPACE']
+          missing = [k for k in required if not os.environ.get(k)]
+          if missing:
+            raise SystemExit(f"Missing required environment variables: {', '.join(missing)}")
+
           today = os.environ['TODAY']
           channel = os.environ['SLACK_CHANNEL_ID']
           snapshots_repo = os.environ['SNAPSHOTS_REPO']
@@ -129,4 +129,6 @@ jobs:
           )
           resp = json.loads(urllib.request.urlopen(req).read())
           print("Slack response:", resp.get('ok'), resp.get('error', ''))
+          if not resp.get('ok'):
+            raise SystemExit(f"Slack error: {resp.get('error')}")
           PYEOF

.github/workflows/weekly-chromatic.yml

@@ -74,6 +74,11 @@ jobs:
           import json, os, urllib.request
           from datetime import date
 
+          required = ['SLACK_TSDIFF_CHROMATIC_BOT_TOKEN', 'SLACK_CHANNEL_ID']
+          missing = [k for k in required if not os.environ.get(k)]
+          if missing:
+            raise SystemExit(f"Missing required environment variables: {', '.join(missing)}")
+
           today = date.today().isoformat()
           channel = os.environ['SLACK_CHANNEL_ID']
           slack_token = os.environ['SLACK_TSDIFF_CHROMATIC_BOT_TOKEN']

scripts/weekly-api-diff/prompt.md

@@ -56,10 +56,7 @@ This also takes 10-30 minutes.
 
 ```bash
 cd $HOME/dev/react-spectrum
-yarn compare:apis \
-  --branch-api-dir=$HOME/dev/react-spectrum/dist/branch-api \
-  --base-api-dir=$HOME/dev/react-spectrum/dist/base-api \
-  --isCI 2>&1 | tee $HOME/dev/react-spectrum-api-snapshots/diffs/$TODAY.txt
+yarn compare:apis --isCI 2>&1 | tee $HOME/dev/react-spectrum-api-snapshots/diffs/$TODAY.txt
 ```
 
 Check if the output file is empty:
@@ -86,6 +83,8 @@ ls -t $HOME/dev/react-spectrum-api-snapshots/diffs/*.txt 2>/dev/null | sed -n '2
 
 ```bash
 cd $HOME/dev/react-spectrum-api-snapshots
+git checkout main
+git pull origin main
 git add diffs/$TODAY.txt
 git commit -m "weekly api diff $TODAY"
 git push