fix(react-aria-components): apply overlay id on Popover when no nested Dialog exists

albertdugba · albertdugba · commit aa08cd141b4e · 2026-04-13T23:18:12.000+01:00
diff --git a/packages/react-aria-components/src/Popover.tsx b/packages/react-aria-components/src/Popover.tsx
@@ -94,6 +94,7 @@ export interface PopoverRenderProps {
 }
 
 interface PopoverContextValue extends PopoverProps {
+  id?: string,
   /** Contexts to clear. */
   clearContexts?: Context<any>[]
 }
@@ -224,6 +225,7 @@ function PopoverInner({state, isExiting, UNSTABLE_portalContainer, clearContexts
     <dom.div
       {...mergeProps(filterDOMProps(props, {global: true}), popoverProps)}
       {...renderProps}
+      id={isDialog ? props.id : undefined}
       role={isDialog ? 'dialog' : undefined}
       tabIndex={isDialog ? -1 : undefined}
       aria-label={props['aria-label']}

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,7 @@ export interface PopoverRenderProps {`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`interface PopoverContextValue extends PopoverProps {`
	`97`	`+ id?: string,`
`97`	`98`	`/** Contexts to clear. */`
`98`	`99`	`clearContexts?: Context<any>[]`
`99`	`100`	`}`
`@@ -224,6 +225,7 @@ function PopoverInner({state, isExiting, UNSTABLE_portalContainer, clearContexts`
`224`	`225`	`<dom.div`
`225`	`226`	`{...mergeProps(filterDOMProps(props, {global: true}), popoverProps)}`
`226`	`227`	`{...renderProps}`
	`228`	`+ id={isDialog ? props.id : undefined}`
`227`	`229`	`role={isDialog ? 'dialog' : undefined}`
`228`	`230`	`tabIndex={isDialog ? -1 : undefined}`
`229`	`231`	`aria-label={props['aria-label']}`