MenuItem's render function always passes href

[rothsandro]

Hi,

The Menu documentation for menu item with links mention that the render function can be used to conditionally render a (router) link by checking 'href' in props".

<MenuItem
  {...props}
  render={domProps =>
    'href' in domProps
      ? <RouterLink {...domProps} />
      : <div {...domProps} />
  } />

However, the domProps always contains href it's just undefined for regular menu items. We also have to check if href is not undefined. But this additional checks results in a TS error when returning <div {...domProps} /> because domProps could be anchor props, so we have to type-cast it.

Repro: https://stackblitz.com/edit/87xhexc4?file=src%2FExample.tsx

I assume this comes from useLinkProps():

react-spectrum/packages/react-aria/src/utils/openLink.tsx

Lines 175 to 185 in 86c8a3b

	let router = useRouter();
	const href = router.useHref(props?.href ?? '');
	return {
	href: props?.href ? href : undefined,
	target: props?.target,
	rel: props?.rel,
	download: props?.download,
	ping: props?.ping,
	referrerPolicy: props?.referrerPolicy
	};
	}

Is it expected that href is always set? If yes, should the docs be updated to check for undefined as well and TS users have to type-cast when spreading the props?

Regards,
Sandro