chore: remove box-shadow divider and update focus ring in TableView#10096
Open
yihuiliao wants to merge 3 commits into
Open
chore: remove box-shadow divider and update focus ring in TableView#10096yihuiliao wants to merge 3 commits into
yihuiliao wants to merge 3 commits into
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
approved these changes
May 23, 2026
Member
snowystinger
left a comment
There was a problem hiding this comment.
A little confused about the change to TreeView's root dropzone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some nice-to-haves that we discussed during testing. Also follows up on one comment that Devon make on the original PR here and simplifies things by removing the use of box-shadow and replacing it with borders instead.
So in short the changes are:
https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=1200
Not a blocker for release, just some minor improvements
✅ Pull Request Checklist:
📝 Test Instructions:
Go to S2 storybook and sanity check that using borders for the gray dividers did not change anything in highlight selection (like layout changes when you select and deselect a row)
For the focus ring, make sure to test the focus ring for the entire row but also the cell focus ring. It should closely match what ListView does where the focus ring renders on top of the gray dividers rather flush against it
🧢 Your Project: