chore: Make TSDiff and Chromatic comment in slack thread#10100
Open
LFDanLu wants to merge 3 commits into
Open
Conversation
LFDanLu
added
the
no testing
LFDanLu
commented
May 22, 2026
Comment on lines
+195
to
+198
| model_input_full = open(delta_path).read() if os.path.exists(delta_path) else "" | ||
| TRUNCATE_LIMIT = 8000 | ||
| truncated = len(model_input_full) > TRUNCATE_LIMIT | ||
| model_input = model_input_full[:TRUNCATE_LIMIT] if truncated else model_input_full |
Member
Author
There was a problem hiding this comment.
Will need to come up with a way to shrink the diff/or summarize repetitive parts before sending it to the model since the payload can be too big if so. @snowystinger I think you said you were working on making the TSDiffer clean up its output so that it doesn't show unchanged parts of the API?
|
Build successful! 🎉 |
yihuiliao
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as per feedback from team
✅ Pull Request Checklist:
📝 Test Instructions:
N/A, tested in test channel
🧢 Your Project:
RSP