fix(react-aria-components): pass overlay id to PopoverContext in Dialogue#9807
Open
albertdugba wants to merge 1 commit into
Open
fix(react-aria-components): pass overlay id to PopoverContext in Dialogue#9807albertdugba wants to merge 1 commit into
albertdugba wants to merge 1 commit into
Conversation
devongovett
reviewed
Mar 18, 2026
| [PopoverContext, { | ||
| trigger: 'DialogTrigger', | ||
| triggerRef: buttonRef, | ||
| id: overlayProps.id, |
Member
There was a problem hiding this comment.
Now we are sending the id to both DialogContext and PopoverContext. This is causing the test failures. We could potentially set id to undefined on DialogContext and only send it to PopoverContext, but not sure.
Contributor
Author
There was a problem hiding this comment.
@devongovett Pls I moved the id to PopoverContext only and set it to undefined on DialogContext and also updated related the dialogue test
albertdugba
force-pushed
the
fix/popover-aria-controls-id
branch
from
0c545b0 to
a8d8e43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Issue #9800
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: