feat(suggestions): allow OUTDATED status in auto-fix allowlist

OUTDATED alt-text suggestions are re-detections of previously-FIXED
rows where the producer found the issue still present on the live URL
(after the publish-lag reset gate). The experience-success-studio-ui
PR #1914 surfaces OUTDATED in the Current tab so customers can retry
the deploy, but the auto-fix controller's status gate only accepted
NEW and PENDING_VALIDATION — silently rejecting OUTDATED with 400
inside a 207 response. The UI today treats 2xx as success, so the
customer sees a "Success" toast while nothing actually re-deploys.

This 3-line allowlist relaxation closes the gap. The rest of the
round-trip is already status-agnostic:

  - bulkUpdateStatus is source-status-agnostic (verified in
    spacecat-shared-data-access: no state machine, no transition
    rules, no hooks — just enum membership check on the target value)
  - autofix-worker queries by opportunity_id + IN_PROGRESS, origin
    status is invisible to it
  - alt-text handler reads recommendations[0].altText, writes alt,
    transitions IN_PROGRESS → FIXED — status-agnostic
  - mystique projector and publish-lag reset gate are timestamp-driven,
    not status-driven

So OUTDATED → IN_PROGRESS → (apply) → FIXED is now the supported flow.

Tests:
  - Updated existing assertion to reflect new error message
  - Added new test asserting OUTDATED is accepted, bulkUpdateStatus
    transitions it to IN_PROGRESS, and the 207 response reports
    success=1 / failed=0

All 404 suggestions controller tests pass, no regressions.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: FentPams

src/controllers/suggestions.js

@@ -1151,13 +1151,22 @@ function SuggestionsController(ctx, sqs, env) {
         } else if (
           suggestion.getStatus() === SuggestionModel.STATUSES.NEW
           || suggestion.getStatus() === SuggestionModel.STATUSES.PENDING_VALIDATION
+          // OUTDATED suggestions are re-detections of previously-FIXED rows
+          // where the producer found the issue still present on the live URL
+          // (after the publish-lag reset gate). The UI surfaces them in the
+          // Current tab (alt-text PR #1914) so customers can retry the deploy
+          // — this allowlist makes that retry actually reach the autofix
+          // worker instead of being silently rejected.
+          // bulkUpdateStatus is source-status-agnostic (verified in
+          // spacecat-shared-data-access), so OUTDATED → IN_PROGRESS just works.
+          || suggestion.getStatus() === SuggestionModel.STATUSES.OUTDATED
         ) {
           validSuggestions.push(suggestion);
         } else {
           failedSuggestions.push({
             uuid: suggestion.getId(),
             index: suggestionIds.indexOf(suggestion.getId()),
-            message: 'Suggestion must be in NEW or PENDING_VALIDATION status for auto-fix',
+            message: 'Suggestion must be in NEW, PENDING_VALIDATION, or OUTDATED status for auto-fix',
             statusCode: 400,
           });
         }

test/controllers/suggestions.test.js

@@ -4608,7 +4608,39 @@ describe('Suggestions Controller', () => {
       expect(bulkPatchResponse.suggestions[1]).to.have.property('statusCode', 400);
       expect(bulkPatchResponse.suggestions[0].suggestion).to.exist;
       expect(bulkPatchResponse.suggestions[1].suggestion).to.not.exist;
-      expect(bulkPatchResponse.suggestions[1]).to.have.property('message', 'Suggestion must be in NEW or PENDING_VALIDATION status for auto-fix');
+      expect(bulkPatchResponse.suggestions[1]).to.have.property('message', 'Suggestion must be in NEW, PENDING_VALIDATION, or OUTDATED status for auto-fix');
+    });
+
+    it('autofix suggestion accepts OUTDATED status (re-detect of previously FIXED row)', async () => {
+      // OUTDATED suggestions are surfaced in the Current tab by the alt-text
+      // UI (#1914) so customers can retry a deploy whose previous attempt
+      // didn't stick on the live URL. Allowing OUTDATED through this gate
+      // makes that retry actually reach the autofix worker.
+      const outdatedSugg = { ...suggs[0], status: 'OUTDATED' };
+      mockSuggestion.allByOpportunityId.resolves([mockSuggestionEntity(outdatedSugg)]);
+      mockSuggestion.bulkUpdateStatus.resolves([
+        mockSuggestionEntity({ ...outdatedSugg, status: 'IN_PROGRESS' }),
+      ]);
+
+      const response = await suggestionsControllerWithMock.autofixSuggestions({
+        params: {
+          siteId: SITE_ID,
+          opportunityId: OPPORTUNITY_ID,
+        },
+        data: { suggestionIds: [SUGGESTION_IDS[0]] },
+        ...context,
+      });
+
+      expect(response.status).to.equal(207);
+      const bulkPatchResponse = await response.json();
+      expect(bulkPatchResponse.metadata).to.have.property('total', 1);
+      expect(bulkPatchResponse.metadata).to.have.property('success', 1);
+      expect(bulkPatchResponse.metadata).to.have.property('failed', 0);
+      expect(bulkPatchResponse.suggestions[0]).to.have.property('statusCode', 200);
+      expect(bulkPatchResponse.suggestions[0].suggestion).to.exist;
+      // OUTDATED → IN_PROGRESS transition must occur for the worker to pick it
+      // up via Suggestion.allByOpportunityIdAndStatus(opp, IN_PROGRESS).
+      expect(mockSuggestion.bulkUpdateStatus).to.have.been.calledOnce;
     });
 
     it('groups by relationshipContext.fixTargetPageId when fixTargetGroups is provided for a groupable type', async () => {