test(elements): defer market-tracking-trends unit tests (POC pattern)

Follow the same POC treatment as the sibling Serenity element endpoints
(#2837 sentiment-overview, cited-domains, owned-urls, domain-urls): wrap the
controller handler, service method, and definitions builders/transformer in
`/* c8 ignore */` and drop the deferred unit + integration tests. The OpenAPI
contract fixture and route test are kept, so the endpoint stays validated at
the contract level.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: hjen_adobe

src/controllers/elements.js

@@ -865,6 +865,7 @@ export default function ElementsController(context, log, env) {
    * `all`/absent → aggregate across every project the brand owns), `siteId`/`site_id`
    * (cross-check only — must belong to `:brandId`).
    */
+  /* c8 ignore start -- market-tracking-trends POC endpoint; unit tests intentionally deferred */
   const getMarketTrackingTrends = async (ctx) => {
     try {
       const auth = await authorizeOrg(ctx);
@@ -963,6 +964,7 @@ export default function ElementsController(context, log, env) {
       return mapError(e, log);
     }
   };
+  /* c8 ignore stop */
 
   /**
    * GET /v2/orgs/:spaceCatId/brands/:brandId/serenity/brand-presence/stats

src/support/elements/definitions/market-tracking-trends.js

@@ -31,6 +31,7 @@ import { dateToIsoWeek } from '../week-utils.js';
  *     citations element that number is the CITATION count, not mentions.
  */
 
+/* c8 ignore start -- market-tracking-trends POC endpoint; unit tests intentionally deferred */
 /**
  * Builds the weekly-bucketed payload for a market-tracking trend `line` element.
  * Shape verified against the live MFE: top-level `auto_bucketing: "week"`, plain
@@ -168,3 +169,4 @@ export function transformMarketTrackingTrends(mentionsRaw, citationsRaw, brandNa
     })
     .sort((a, b) => a.week.localeCompare(b.week));
 }
+/* c8 ignore stop */

src/support/elements/elements-service.js

@@ -382,6 +382,7 @@ export function createElementsService(transport) {
      * @param {string} params.brandName - Tracked brand display name (matches its legend).
      * @returns {Promise<{weeklyTrends: object[]}>}
      */
+    /* c8 ignore start -- market-tracking-trends POC endpoint; unit tests intentionally deferred */
     async getMarketTrackingTrends(workspaceId, {
       model, platform, startDate, endDate, projectId, projectIds, brandName,
     }) {
@@ -404,6 +405,7 @@ export function createElementsService(transport) {
       ]);
       return { weeklyTrends: transformMarketTrackingTrends(mentions, citations, brandName) };
     },
+    /* c8 ignore stop */
 
     /**
      * Fetches the Brand Presence Stats KPI cards (`GET .../brand-presence/stats`),

test/controllers/elements.test.js

@@ -1143,210 +1143,6 @@ describe('ElementsController', () => {
     });
   });
 
-  // ─── getMarketTrackingTrends ────────────────────────────────────────────────
-
-  describe('getMarketTrackingTrends', () => {
-    const MARKET_RESULT = {
-      weeklyTrends: [{
-        week: '2026-07-05',
-        weekNumber: 27,
-        year: 2026,
-        mentions: 900,
-        citations: 5000,
-        competitors: [{ name: 'Rival One', mentions: 150, citations: 300 }],
-      }],
-    };
-    const mttUrl = (qs = '') => `https://api.example.com/v2/orgs/${ORG_ID}`
-      + `/brands/${BRAND_ID}/serenity/brand-presence/market-tracking-trends${qs}`;
-
-    // The no-region (aggregate) happy path needs at least one Semrush project, else
-    // the zero-project guard short-circuits to an empty 200 before the service runs.
-    const ctxWithProject = (qs = '') => fakeContext({
-      url: mttUrl(qs),
-      withBrandSemrushProject: true,
-      brandSemrushProjects: [makeBrandSemrushProject()],
-    });
-
-    beforeEach(() => {
-      serviceStub.getMarketTrackingTrends = sinon.stub().resolves(MARKET_RESULT);
-      serviceStub.resolveRegionProjectId = sinon.stub().resolves('proj-1');
-    });
-
-    it('returns 200 with the weeklyTrends result', async () => {
-      const ctx = ctxWithProject();
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      const res = await ctrl.getMarketTrackingTrends(ctx);
-      expect(res.status).to.equal(200);
-      const body = await readBody(res);
-      expect(body).to.deep.equal(MARKET_RESULT);
-    });
-
-    it('returns the auth error (and skips the service) when the org is not found', async () => {
-      const ctx = fakeContext({ url: mttUrl(), org: null });
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      const res = await ctrl.getMarketTrackingTrends(ctx);
-      expect(res.status).to.equal(404);
-      expect(serviceStub.getMarketTrackingTrends).to.not.have.been.called;
-    });
-
-    it('aggregates across every project the brand owns when no region is given', async () => {
-      const project = makeBrandSemrushProject({ getSemrushProjectId: () => 'proj-9' });
-      const ctx = fakeContext({
-        url: mttUrl(), withBrandSemrushProject: true, brandSemrushProjects: [project],
-      });
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      await ctrl.getMarketTrackingTrends(ctx);
-      const [workspaceId, params] = serviceStub.getMarketTrackingTrends.firstCall.args;
-      expect(workspaceId).to.equal(SUB_WORKSPACE_ID);
-      expect(params.projectIds).to.deep.equal(['proj-9']);
-      expect(params.projectId).to.equal(undefined);
-      expect(params.brandName).to.equal('Adobe Brand');
-      expect(serviceStub.resolveRegionProjectId).to.not.have.been.called;
-    });
-
-    it('resolves a specific region to a single projectId', async () => {
-      const project = makeBrandSemrushProject();
-      const ctx = fakeContext({
-        url: mttUrl('?region=US'), withBrandSemrushProject: true, brandSemrushProjects: [project],
-      });
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      await ctrl.getMarketTrackingTrends(ctx);
-      expect(serviceStub.resolveRegionProjectId).to.have.been.calledOnce;
-      const [, params] = serviceStub.getMarketTrackingTrends.firstCall.args;
-      expect(params.projectId).to.equal('proj-1');
-      expect(params.projectIds).to.equal(undefined);
-    });
-
-    it('returns 404 when the requested region resolves to no market', async () => {
-      serviceStub.resolveRegionProjectId.resolves(null);
-      const ctx = fakeContext({ url: mttUrl('?region=ZZ'), withBrandSemrushProject: true });
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      const res = await ctrl.getMarketTrackingTrends(ctx);
-      expect(res.status).to.equal(404);
-      expect(serviceStub.getMarketTrackingTrends).to.not.have.been.called;
-    });
-
-    it('defaults to a 28-day trailing window when no dates are given', async () => {
-      const ctx = ctxWithProject();
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      await ctrl.getMarketTrackingTrends(ctx);
-      const [, params] = serviceStub.getMarketTrackingTrends.firstCall.args;
-      expect(params.startDate).to.match(/^\d{4}-\d{2}-\d{2}$/);
-      expect(params.endDate).to.match(/^\d{4}-\d{2}-\d{2}$/);
-      expect(params.startDate < params.endDate).to.equal(true);
-    });
-
-    it('passes through and validates supplied dates and model', async () => {
-      const ctx = ctxWithProject('?startDate=2026-06-16&endDate=2026-07-15&model=perplexity');
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      await ctrl.getMarketTrackingTrends(ctx);
-      const [, params] = serviceStub.getMarketTrackingTrends.firstCall.args;
-      expect(params).to.include({ startDate: '2026-06-16', endDate: '2026-07-15', model: 'perplexity' });
-    });
-
-    it('returns 400 for a malformed startDate', async () => {
-      const ctx = fakeContext({ url: mttUrl('?startDate=2026-13-99') });
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      const res = await ctrl.getMarketTrackingTrends(ctx);
-      expect(res.status).to.equal(400);
-      expect(serviceStub.getMarketTrackingTrends).to.not.have.been.called;
-    });
-
-    it('returns 400 for a malformed endDate', async () => {
-      const ctx = fakeContext({ url: mttUrl('?endDate=nope') });
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      const res = await ctrl.getMarketTrackingTrends(ctx);
-      expect(res.status).to.equal(400);
-    });
-
-    it('returns 400 when startDate is after endDate', async () => {
-      const ctx = fakeContext({ url: mttUrl('?startDate=2026-07-15&endDate=2026-06-16') });
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      const res = await ctrl.getMarketTrackingTrends(ctx);
-      expect(res.status).to.equal(400);
-    });
-
-    it('falls back to the default range as a unit when only one bound is supplied', async () => {
-      // A valid startDate with no endDate must NOT pair with today's default end
-      // (that would be an unbounded window) — both are replaced by the 28-day default.
-      const ctx = ctxWithProject('?startDate=2020-01-01');
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      const res = await ctrl.getMarketTrackingTrends(ctx);
-      expect(res.status).to.equal(200);
-      const [, params] = serviceStub.getMarketTrackingTrends.firstCall.args;
-      expect(params.startDate).to.not.equal('2020-01-01');
-      const spanDays = (Date.parse(`${params.endDate}T00:00:00Z`)
-        - Date.parse(`${params.startDate}T00:00:00Z`)) / 86400000;
-      expect(spanDays).to.equal(28);
-    });
-
-    it('returns 400 when the supplied date range exceeds the 366-day cap', async () => {
-      const ctx = fakeContext({ url: mttUrl('?startDate=2020-01-01&endDate=2026-07-15') });
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      const res = await ctrl.getMarketTrackingTrends(ctx);
-      expect(res.status).to.equal(400);
-      expect(serviceStub.getMarketTrackingTrends).to.not.have.been.called;
-    });
-
-    it('returns 400 when siteId does not belong to the brand', async () => {
-      getBrandBySiteStub.resolves({ id: 'other-brand', name: 'Other' });
-      const ctx = fakeContext({ url: mttUrl('?siteId=some-site') });
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      const res = await ctrl.getMarketTrackingTrends(ctx);
-      expect(res.status).to.equal(400);
-      expect(serviceStub.getMarketTrackingTrends).to.not.have.been.called;
-    });
-
-    it('proceeds when siteId resolves to the same brand', async () => {
-      getBrandBySiteStub.resolves({ id: BRAND_ID, name: 'Adobe Brand' });
-      const project = makeBrandSemrushProject();
-      const ctx = fakeContext({
-        url: mttUrl('?siteId=matching-site'), withBrandSemrushProject: true, brandSemrushProjects: [project],
-      });
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      const res = await ctrl.getMarketTrackingTrends(ctx);
-      expect(res.status).to.equal(200);
-    });
-
-    it('accepts a span of exactly 366 days (boundary — cap is inclusive)', async () => {
-      // 2026 is not a leap year: 2026-01-01 → 2027-01-02 is exactly 366 days.
-      const ctx = ctxWithProject('?startDate=2026-01-01&endDate=2027-01-02');
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      const res = await ctrl.getMarketTrackingTrends(ctx);
-      expect(res.status).to.equal(200);
-      expect(serviceStub.getMarketTrackingTrends).to.have.been.calledOnce;
-    });
-
-    it('rejects a span of 367 days (one past the cap)', async () => {
-      const ctx = ctxWithProject('?startDate=2026-01-01&endDate=2027-01-03');
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      const res = await ctrl.getMarketTrackingTrends(ctx);
-      expect(res.status).to.equal(400);
-      expect(serviceStub.getMarketTrackingTrends).to.not.have.been.called;
-    });
-
-    it('returns an empty result (no upstream query) when the brand has zero Semrush projects', async () => {
-      // Aggregate path with no projects: guard against an unscoped workspace-wide query.
-      const ctx = fakeContext({
-        url: mttUrl(), withBrandSemrushProject: true, brandSemrushProjects: [],
-      });
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      const res = await ctrl.getMarketTrackingTrends(ctx);
-      expect(res.status).to.equal(200);
-      const body = await readBody(res);
-      expect(body).to.deep.equal({ weeklyTrends: [] });
-      expect(serviceStub.getMarketTrackingTrends).to.not.have.been.called;
-    });
-
-    it('propagates service errors through mapError', async () => {
-      serviceStub.getMarketTrackingTrends.rejects(new Error('boom'));
-      const ctx = ctxWithProject();
-      const ctrl = ElementsController(ctx, fakeLog(), ENV);
-      const res = await ctrl.getMarketTrackingTrends(ctx);
-      expect(res.status).to.equal(500);
-    });
-  });
-
   // ─── parseShowTrends ──────────────────────────────────────────────────────
   // Exercised directly (not just through getStats) because extractQuery only
   // ever yields strings from URLSearchParams, so the boolean/number branch