fix(llmo): align prompt-suggestion triggers with confirmed createSchedule signature

Match the shared drs-client createSchedule contract (confirmed):
- providerIds is an ARRAY (job_config.provider_ids envelope) — pass a
  one-element array per single-provider pipeline.
- cadence enum values use underscores: 'twice_monthly' / 'quarterly'
  (SCHEDULE_CADENCES); the client derives the cron server-side.
- drop orgId/imsOrgId entirely: DRS derives the tenant-isolation key from
  site_id server-side and rejects any caller-supplied imsOrgId, so it must not
  be threaded through createSchedule.
- add a length-capped description; priority defaults HIGH in the client.

Also harden the new Phase 3 before-hook with an explicit timeout for cold
esmock module loads.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: dzehnder

src/controllers/llmo/llmo-onboarding.js

@@ -176,13 +176,18 @@ export async function triggerBrandalfOnboardingJob({
 }
 
 // Cadence labels accepted by DRS `createSchedule` for the recurring
-// "prompt suggestion" pipelines. DRS derives the concrete cron expression
-// server-side from the label (frequency:'cron') — we never send raw cron, so a
-// misconfigured/leaked caller cannot schedule a fleet-wide Fargate storm.
-//   'twice-monthly' → 1st & 15th (honest label; not a true 14-day interval)
+// "prompt suggestion" pipelines (the `SCHEDULE_CADENCES` enum in the drs-client).
+// DRS derives the concrete cron expression server-side from the label
+// (frequency:'cron', with per-site hour jitter for twice_monthly) — we never send
+// raw cron, so a misconfigured/leaked caller cannot schedule a fleet-wide Fargate
+// storm; an unknown value is rejected server-side.
+//   'twice_monthly' → 1st & 15th (honest label; not a true 14-day interval)
 //   'quarterly'     → 1st of Jan/Apr/Jul/Oct
+// Kept as local literals (matching SCHEDULE_CADENCES values) so this module loads
+// against the currently-installed client; can be swapped for the imported
+// SCHEDULE_CADENCES const once drs-client 1.14.0 is installed.
 // See local/drs-prompt-suggestions-schedules-onboarding-plan.md ("Cadence expression").
-const DRS_CADENCE_TWICE_MONTHLY = 'twice-monthly';
+const DRS_CADENCE_TWICE_MONTHLY = 'twice_monthly';
 const DRS_CADENCE_QUARTERLY = 'quarterly';
 
 /**
@@ -196,19 +201,21 @@ const DRS_CADENCE_QUARTERLY = 'quarterly';
  * schedule and nothing self-heals, so it propagates to the caller which logs it
  * at ERROR. This helper therefore does not swallow the failure itself.
  *
+ * NOTE: `createSchedule` derives the tenant-isolation key from `siteId`
+ * server-side and REJECTS any caller-supplied imsOrgId, so we deliberately do not
+ * thread imsOrgId/orgId into it.
+ *
  * @param {object} params
  * @param {object} params.drsClient - Configured DRS client.
  * @param {string} params.providerId - DRS provider id to schedule.
  * @param {string} params.cadence - One of DRS_CADENCE_* labels.
  * @param {string} params.siteId - SpaceCat site UUID.
- * @param {string} params.orgId - SpaceCat organization UUID.
- * @param {string} params.imsOrgId - IMS org id (isolation key; DRS re-derives server-side).
  * @param {object} params.log - Logger.
  * @param {Function} [params.say] - Optional Slack say callback.
  * @returns {Promise<object|null>} The createSchedule result, or null when DRS is not configured.
  */
 async function registerPromptSuggestionSchedule({
-  drsClient, providerId, cadence, siteId, orgId, imsOrgId, log, say = () => {},
+  drsClient, providerId, cadence, siteId, log, say = () => {},
 }) {
   if (!drsClient.isConfigured()) {
     log.debug(`DRS client not configured, skipping ${providerId} schedule for site ${siteId}`);
@@ -217,13 +224,13 @@ async function registerPromptSuggestionSchedule({
 
   // Default enable_brand_presence off (plan Phase 0.4): these prompt-suggestion
   // pipelines must not push unexpected load into the brand-presence pipeline / SNS
-  // allowlist unless a site is explicitly BP-enabled.
+  // allowlist unless a site is explicitly BP-enabled. `providerIds` is an array
+  // (the job_config.provider_ids envelope) even for a single-provider pipeline.
   const result = await drsClient.createSchedule({
     siteId,
-    providerId,
+    providerIds: [providerId],
     cadence,
-    orgId,
-    imsOrgId,
+    description: `${providerId} prompt-suggestion schedule (onboarding)`,
     enableBrandPresence: false,
     triggerImmediately: true,
   });
@@ -1550,8 +1557,6 @@ export async function activateBrandAndGeneratePrompts({
           await trigger({
             drsClient: scheduleDrsClient,
             siteId: site.getId(),
-            orgId: organization.getId(),
-            imsOrgId,
             log,
             say,
           });

test/controllers/llmo/llmo-onboarding.test.js

@@ -5763,7 +5763,10 @@ describe('LLMO Onboarding Functions', () => {
     let onboardingModule;
     let sandbox;
 
-    before(async () => {
+    before(async function loadOnboardingModule() {
+      // Cold esmock load of the onboarding module (which pulls in many deps) can
+      // exceed the 2000ms default on a first, un-warmed run.
+      this.timeout(30000);
       onboardingModule = await esmock('../../../src/controllers/llmo/llmo-onboarding.js', {});
     });
 
@@ -5784,17 +5787,15 @@ describe('LLMO Onboarding Functions', () => {
     const buildParams = (drsClient) => ({
       drsClient,
       siteId: 'site-123',
-      orgId: 'org-123',
-      imsOrgId: 'ABC123@AdobeOrg',
       log: {
         info: sandbox.stub(), debug: sandbox.stub(), warn: sandbox.stub(), error: sandbox.stub(),
       },
       say: sandbox.stub(),
     });
 
     const HELPERS = [
-      ['triggerSemrushPromptJob', 'prompt_generation_semrush', 'twice-monthly'],
-      ['triggerCitationAttemptJob', 'prompt_generation_agentic_traffic', 'twice-monthly'],
+      ['triggerSemrushPromptJob', 'prompt_generation_semrush', 'twice_monthly'],
+      ['triggerCitationAttemptJob', 'prompt_generation_agentic_traffic', 'twice_monthly'],
       ['triggerSyntheticPersonasJob', 'prompt_generation_synthetic_personas', 'quarterly'],
     ];
 
@@ -5804,15 +5805,17 @@ describe('LLMO Onboarding Functions', () => {
         const result = await onboardingModule[fnName](buildParams(drsClient));
 
         expect(drsClient.createSchedule).to.have.been.calledOnce;
-        expect(drsClient.createSchedule.firstCall.args[0]).to.deep.include({
+        const arg = drsClient.createSchedule.firstCall.args[0];
+        expect(arg).to.deep.include({
           siteId: 'site-123',
-          orgId: 'org-123',
-          imsOrgId: 'ABC123@AdobeOrg',
-          providerId,
           cadence,
           enableBrandPresence: false,
           triggerImmediately: true,
         });
+        expect(arg.providerIds).to.deep.equal([providerId]);
+        // DRS derives the tenant key from siteId and rejects caller imsOrgId — never thread it.
+        expect(arg).to.not.have.property('imsOrgId');
+        expect(arg).to.not.have.property('orgId');
         expect(result).to.deep.equal({ scheduleId: 'sched-1', alreadyExisted: false });
       });
 
@@ -5892,7 +5895,7 @@ describe('LLMO Onboarding Functions', () => {
       const instance = mockDrsClient.createFrom();
       expect(instance.submitJob).to.have.been.calledOnce; // Brandalf fired first
       expect(instance.createSchedule).to.have.been.calledThrice;
-      const providerIds = instance.createSchedule.getCalls().map((c) => c.args[0].providerId);
+      const providerIds = instance.createSchedule.getCalls().map((c) => c.args[0].providerIds[0]);
       expect(providerIds).to.have.members([
         'prompt_generation_semrush',
         'prompt_generation_agentic_traffic',