test(llmo): cover rescanCdnLogDelivery branches for codecov/patch (LLMO-5566)

- Remove dead !Organization early-return from gateEdgeOptimizeWizard
- Add test for custom EDGE_OPTIMIZE_ROLE_NAME env var path
- Add test for rejection with no .message (covers 'unknown error' fallback)

Introduced by: #2680

Author: cboldis

src/controllers/llmo/llmo.js

@@ -2349,7 +2349,7 @@ function LlmoController(ctx) {
   // must have access to the site and be an LLMO administrator. Returns { error } (a Response)
   // when denied, or { site, imsOrgId, externalId } when allowed. Pass Organization to also
   // derive the org-scoped ExternalId used by assumeConnectorRole.
-  const gateEdgeOptimizeWizard = async (siteId, Site, action, Organization = null) => {
+  const gateEdgeOptimizeWizard = async (siteId, Site, action, Organization) => {
     const site = await Site.findById(siteId);
     if (!site) {
       return { error: notFound('Site not found') };
@@ -2360,9 +2360,6 @@ function LlmoController(ctx) {
     if (!accessControlUtil.isLLMOAdministrator()) {
       return { error: forbidden(`Only LLMO administrators can ${action}`) };
     }
-    if (!Organization) {
-      return { site };
-    }
     const organization = await Organization.findById(site.getOrganizationId());
     const imsOrgId = organization?.getImsOrgId();
     if (!hasText(imsOrgId)) {

test/controllers/llmo/llmo.test.js

@@ -8149,6 +8149,30 @@ describe('LlmoController', () => {
       expect(body.distributions[1].error).to.equal('AccessDenied');
     });
 
+    it('uses a custom role name when EDGE_OPTIMIZE_ROLE_NAME is set', async () => {
+      const ctx = {
+        ...rescanContext,
+        env: { ...rescanContext.env, EDGE_OPTIMIZE_ROLE_NAME: 'CustomConnectorRole' },
+      };
+
+      const result = await controller.rescanCdnLogDelivery(ctx);
+
+      expect(result.status).to.equal(200);
+      const callArgs = assumeConnectorRoleStub.firstCall.args[0];
+      expect(callArgs.roleName).to.equal('CustomConnectorRole');
+    });
+
+    it('falls back to "unknown error" when a rejection has no message', async () => {
+      createCdnLogDeliveryStub.onFirstCall().resolves({ created: true, alreadyExisted: false });
+      createCdnLogDeliveryStub.onSecondCall().rejects('non-error rejection');
+
+      const result = await controller.rescanCdnLogDelivery(rescanContext);
+
+      expect(result.status).to.equal(200);
+      const body = await result.json();
+      expect(body.distributions[1].error).to.equal('unknown error');
+    });
+
     it('returns 400 for an invalid account id', async () => {
       const result = await controller.rescanCdnLogDelivery({
         ...rescanContext,