feat: route path-level prerender suggestions through deploy and rollback#2383
Merged
Conversation
Open
5 tasks
|
This PR will trigger a minor release when merged. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
… edgeDeployed check
…ollbackSuggestions
…ient applies context-specific updatedBy fallbacks
dipratap
approved these changes
Jun 1, 2026
dipratap
left a comment
Contributor
There was a problem hiding this comment.
Please check if the package-lock changes are correct
dipratap
reviewed
Jun 1, 2026
dipratap
reviewed
Jun 1, 2026
solaris007
pushed a commit
that referenced
this pull request
Jun 1, 2026
# [1.535.0](v1.534.0...v1.535.0) (2026-06-01) ### Features * route path-level prerender suggestions through deploy and rollback ([#2383](#2383)) ([9f04beb](9f04beb)), closes [adobe/spacecat-shared#1598](adobe/spacecat-shared#1598)
Member
|
🎉 This PR is included in version 1.535.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deployToEdge/rollbackSuggestionFromEdgeflowallowedRegexPatterns); delegates totokowakaClient.deployToEdgewhich handles per-URL and pattern suggestions uniformlytokowakaClient.rollbackSuggestionswithallSuggestionsfor cascade cleanup; the shared client handles all three rollback types (per-URL, path-level pattern, domain-wide pattern) plus the domain-wide → path cascadeprofile?.emailis passed directly (without fallback) torollbackSuggestionsso the shared client can apply context-specificupdatedByfallback strings:'tokowaka-rollback'for the suggestion being rolled back'domain-wide-rollback'for per-URL suggestions covered by a domain-wide pattern'path-rollback'for per-URL suggestions covered by a path pattern'domain-wide-rollback-cascade'for path suggestions and their covered entries cleaned up as part of a domain-wide rollbackDepends on: adobe/spacecat-shared#1598
Test plan
allowedRegexPatterns, success path callsdeployToEdgewith correct argsrollbackSuggestionscalled withupdatedBy: profile.emailrollbackSuggestionscalled withupdatedBy: undefined(shared client applies correct fallbacks)allSuggestionspassed so shared client can clean up deployed path suggestions and their covered entries🤖 Generated with Claude Code