feat(SITES-43695): use org.defaultSiteId in resolveSite to bypass insertion-order fallback#2434
Open
prithipalpatwal wants to merge 4 commits into
Open
feat(SITES-43695): use org.defaultSiteId in resolveSite to bypass insertion-order fallback#2434prithipalpatwal wants to merge 4 commits into
prithipalpatwal wants to merge 4 commits into
Conversation
prithipalpatwal
force-pushed
the
feat/SITES-43695-resolve-defaultSiteId
branch
from
5f549f6 to
a9887fd
Compare
|
This PR will trigger a minor release when merged. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Per-product default site is stored as config.defaults.{productCode}.siteId
on the organization config so customers can pin a preferred domain without
insertion-order dependence on getFirstEnrollment.
Changes:
- sites.js: resolveOrgDefaultSite reads org.getConfig()?.defaults?.[productCode]?.siteId
before falling back to getFirstEnrollment; try/catch ensures TierClient errors
fall through gracefully; warns on stale or cross-org config.defaults entries
- organizations.js: PATCH validates config.defaults entries (product code, siteId UUID,
site ownership); comment documents setConfig/updates ordering dependency
- dto/organization.js: remove defaultSiteId from toJSON
- docs/openapi/schemas.yaml: document defaults.{productCode}.siteId structure on
OrganizationConfig; remove obsolete defaultSiteId field
- tests: full edge-case coverage for both the org PATCH validation and the
resolveSite config.defaults resolution paths
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…t public API Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
prithipalpatwal
force-pushed
the
feat/SITES-43695-resolve-defaultSiteId
branch
from
075816f to
c70c9f7
Compare
… code only Remove siteId-specific validation from the PATCH org config.defaults block so the structure is not locked to a single field. Only product code membership is validated; entry shape is left to the caller. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
If a config.defaults entry contains a siteId field, validate it is a valid UUID and belongs to the organization. Entries without siteId are accepted as-is, keeping the structure open to other fields per product. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
describe here the problem you're solving.
If the PR is changing the API specification:
yet. Ideally, return a 501 status code with a message explaining the feature is not implemented yet.
If the PR is changing the API implementation or an entity exposed through the API:
If the PR is introducing a new audit type:
Related Issues
Thanks for contributing!