Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.corp.adobe.com/browse/LLMO-5307
Summary
Adds
granularity=dayquery parameter toGET /org/:spaceCatId/brands/{all|:brandId}/brand-presence/sentiment-overview.granularityor passingweekproduces the existingweeklyTrendsresponse unchanged (now also includesgranularity: "week"anddailyTrends: [])granularity=dayreturns one bucket per calendar date indailyTrends; each entrycarries
date(YYYY-MM-DD),week(ISO week string), and the same sentiment/promptshape as weekly
p_granularityto the RPC (requires the mysticat-data-service migration deployed first)aggregateSentimentByDayas a JS reference implementation and test oracle(same dedup and percentage rules as
aggregateSentimentByWeek)Files changed
src/controllers/llmo/llmo-brand-presence.jsaggregateSentimentByDay, updatedcreateSentimentOverviewHandlertest/controllers/llmo/llmo-brand-presence.test.jsTest plan
npm testpasses (11 k+ tests, no regressions)granularityparam) → response shape unchanged,weeklyTrendspopulatedgranularity=daywith 28-day range →dailyTrendsarray, one entry per dategranularity=daywith 91-day range → 400Date range too large for daily granularity (max 90 days)granularity=month→ 400granularity must be 'week' or 'day'Deploy order
granularity=dayfor daily-prompt sites) — separate PR