Skip to content

feat(geo-experiment): add table-of-contents to supported opportunity types (LLMO-5611) #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anagarwa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(geo-experiment): add table-of-contents to supported opportunity types (LLMO-5611) #2608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion src/support/geo-experiment-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,18 @@

import { GeoExperiment } from '@adobe/spacecat-shared-data-access';

/**
* Supported opportunity types for EXPERIMENT_SCHEDULE_CONFIG.
* Each key must match the opportunity type string lowercased
* (e.g. 'recover-content-visibility', 'table-of-contents').
* The geo-experiment flow is fully generic — any opportunity type works at runtime —
* but types listed here have documented, tested schedule-config support.
*/
export const SUPPORTED_GEO_EXPERIMENT_OPPORTUNITY_TYPES = [
'recover-content-visibility',
'table-of-contents',
];

/**
* Validates a single phase config block.
* All fields are optional — only present fields are validated.
Expand Down Expand Up @@ -51,6 +63,18 @@ function validatePhaseConfig(phaseConfig, path) {
* }
* }
*
* Example with known opportunity types:
* {
* "onsite_opportunity_deployment": {
* "default": { "pre": { ... }, "post": { ... } },
* "recover-content-visibility": { "pre": { ... }, "post": { ... } },
* "table-of-contents": {
* "pre": { "cronExpression": "0 0/6 * * *", "expiryMs": 259200000 },
* "post": { "cronExpression": "0 0 * * 1", "expiryMs": 1209600000 }
* }
* }
* }
*
* @param {object} env
* @returns {object|null}
*/
Expand Down Expand Up @@ -111,7 +135,7 @@ export function parseScheduleConfig(env, log) {
*
* @param {object} env
* @param {string} strategyType - e.g. GeoExperiment.TYPES.ONSITE_OPPORTUNITY_DEPLOYMENT
* @param {string} opportunityType - e.g. "recover-content-visibility"
* @param {string} opportunityType - e.g. "recover-content-visibility" or "table-of-contents"
* @param {'pre'|'post'} phase
* @returns {object}
*/
Expand Down
Loading