fix(serenity): add required type to brand-alias updateProject PATCH

[rainer-friederich]

1. Abstract

Adds the required type: 'ai' field to the serenity brand-alias re-sync updateProject PATCH body so the request validates against the Semrush Project Engine gateway.

2. Reasoning

The brand-alias re-sync in src/support/serenity/brand-aliases.js called transport.updateProject(...) with a body that omitted the type field, which is required on ProjectUpdateRequest. A live sweep (captured 2026-06-29) confirmed that a typeless PATCH /v1/workspaces/{id}/projects/{pid} returns 400 (Key: 'ProjectUpdateRequest.Type' Error:Field validation for 'Type' failed on the 'required' tag), while the same PATCH with type: 'ai' returns 200. As a result, any brand-alias change that actually drifts a project's brand_names would fail in production and silently no-op the project-level alias sync. The gap went uncaught because no IT exercised the alias-resync PATCH path against the PE mock, even though the mock already 400s a typeless PATCH.

3. High-level overview of the changes

• Before: the brand_names re-sync branch sent { brand_name_display?, brand_names } — no type — so a drifted update 400'd against the live gateway and the alias sync silently failed.
• After: the PATCH body carries type: 'ai' (matching the literal used at project create-time in handlers/markets.js and handlers/markets-subworkspace.js; AIO projects are always type ai), so the request validates and the drifted brand_names update succeeds.
• Behaviour is otherwise unchanged: the PATCH still fires only when the live brand_names set has drifted from the desired set; the benchmark brand_aliases PUT path is untouched.
• The three exact-body assertions in the unit test now pin type: 'ai', so a future regression that drops the field is caught locally.

4. Required information

• Jira / issue: serenity updateProject omits required type — brand-alias PATCH 400s against live Semrush #2720
• Other: fix(project-engine-client, user-manager-client): round-trip created+published market + live-fidelity sweep (#1745) spacecat-shared#1746

5. Affected / used mysticat-workspace projects

• spacecat-shared (contract): the PE Counterfact mock enforces the type requirement at the request-validation seam; spacecat-shared PR feat: support running against a local spacecat instance | LLMO-2816 #1746 pins the typeless-PATCH 400 as an e2e. This change makes serenity conform to that contract.

7. Test plan

• (a) Local: ran the brand-aliases unit suite, which now asserts type: 'ai' on all three updateProject body expectations; the serenity // @ts-check type-check gate also covers the touched file. No live e2e was run this session — the production defect was identified from the 2026-06-29 live Semrush sweep referenced in the issue.
• (b) dev / stage / prod: after deploy, trigger a brand-alias change that drifts a serenity-mode brand's brand_names (display name or alias edit) and confirm the PATCH /v1/workspaces/{id}/projects/{pid} returns 200 rather than 400, and that the project's settings.ai.brand_names reflects the new set.

8. Deployment & merge order

• fix(project-engine-client, user-manager-client): round-trip created+published market + live-fidelity sweep (#1745) spacecat-shared#1746 (related): pins the mock-level typeless-PATCH 400 guard upstream. Independent of this PR — no hard merge/deploy ordering required; the two together guard the defect at both the mock layer and the serenity call site.

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[MysticatBot]

Hey @rainer-friederich,

Verdict: Approve - clean, well-scoped bug fix with adequate test coverage.
Complexity: TRIVIAL - 6 lines, 2 files, single call-site fix.
Changes: Adds the required type: 'ai' field to the brand-alias re-sync updateProject PATCH body so it validates against the Semrush Project Engine gateway (2 files).

---

_{Skill: pr-review | Model: us.anthropic.claude-opus-4-6-v1[1m] | Duration: 0m 43s | Cost: $2.00 | Commit: 3173a31bba38c062f019f5f0b006545f75c38398
If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[github-actions]

This PR will trigger a patch release when merged.

[solaris007]

🎉 This PR is included in version 1.609.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀