Skip to content

fix: move read-only lookup routes (regions, brand-presence stats) to capability-gated access #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravverma merged 5 commits into from
Jul 15, 2026
+6 −7
Merged

fix: move read-only lookup routes (regions, brand-presence stats) to capability-gated access #2819

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
355740e
fix: moving region end point to required capability with read
ravverma Jul 15, 2026
c32296f
fix: correct stale S2S comment on GET /v2/regions capability entry
ravverma Jul 15, 2026
86f11b9
fix: wrap GET /v2/regions capability comment to satisfy max-len lint
ravverma Jul 15, 2026
15455c8
Merge branch 'main' into read-only-org-end-point
ravverma Jul 15, 2026
31ee86c
fix: move brand-presence/stats routes to brand:read capability
ravverma Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/routes/required-capabilities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,6 @@ export const INTERNAL_ROUTES = [
'POST /slack/events',
'POST /slack/channels/invite-by-user-id',

// Brand Presence stats - org-scoped, LLMO product; not yet required by S2S consumers
'GET /org/:spaceCatId/brands/all/brand-presence/stats',
'GET /org/:spaceCatId/brands/:brandId/brand-presence/stats',

// Agentic traffic PG dashboard endpoints (site-scoped) - non-mutating POST queries
// (complex payloads / export trigger); UI only, not yet required by S2S
'POST /sites/:siteId/agentic-traffic/hits-by-urls',
Expand Down Expand Up @@ -173,9 +169,6 @@ export const INTERNAL_ROUTES = [
'POST /ephemeral-run/batch',
'GET /ephemeral-run/batch/:batchId/status',

// Regions lookup - global table, no org scope; session-token authenticated, not for S2S consumers
'GET /v2/regions',

// Monitoring - DRS Brand Presence PostgREST audit proxy. Called by DRS monitoring workers
// via admin x-api-key only (DRS runs in a separate AWS account and holds no S2S consumer
// registration). Kept internal because reusing `audit:read` would silently broaden that
Expand Down Expand Up @@ -257,6 +250,10 @@ const routeRequiredCapabilities = {
'PUT /configurations/latest/handlers/:handlerType/replace-enabled-disabled': CAP_CONFIGURATION_WRITE,
'PATCH /configurations/sites/audits': CAP_CONFIGURATION_WRITE,

// Regions lookup - global table, no org scope; readable by any consumer
// (session-token or S2S) holding organization:read
'GET /v2/regions': 'organization:read',

Comment thread
ravverma marked this conversation as resolved.
// Organizations
'GET /organizations': CAP_ORG_READ_ALL,
'POST /organizations': 'organization:write',
Expand Down Expand Up @@ -319,6 +316,8 @@ const routeRequiredCapabilities = {
'GET /org/:spaceCatId/brands/:brandId/fanout-report': 'brand:read',
'GET /org/:spaceCatId/brands/all/brand-presence/filter-dimensions': 'brand:read',
'GET /org/:spaceCatId/brands/:brandId/brand-presence/filter-dimensions': 'brand:read',
'GET /org/:spaceCatId/brands/all/brand-presence/stats': 'brand:read',
'GET /org/:spaceCatId/brands/:brandId/brand-presence/stats': 'brand:read',
'GET /org/:spaceCatId/brands/all/brand-presence/weeks': 'brand:read',
'GET /org/:spaceCatId/brands/:brandId/brand-presence/weeks': 'brand:read',
'GET /org/:spaceCatId/brands/all/brand-presence/sentiment-overview': 'brand:read',
Expand Down
Loading