fix(wikipedia): handle branded TLDs in extractBrandFromUrl#2557
Merged
Conversation
hdfc.bank.in was resolving to companyName=bank instead of hdfc because .bank was not recognized as a multi-part TLD prefix. Add bank, firm, gen, ind, res, nic to the prefix set (India ccSLD patterns). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
HollywoodTonight
temporarily deployed
to
dev-branches
GitHub Actions
Inactive
rarescheseli
approved these changes
May 25, 2026
solaris007
pushed a commit
that referenced
this pull request
May 25, 2026
## [1.450.2](v1.450.1...v1.450.2) (2026-05-25) ### Bug Fixes * **wikipedia:** handle branded TLDs in extractBrandFromUrl ([#2557](#2557)) ([2279b9b](2279b9b))
Member
|
🎉 This PR is included in version 1.450.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractBrandFromUrl('hdfc.bank.in')was returningbankinstead ofhdfcbecause.bankwasn't recognized as a multi-part TLD prefixbank,firm,gen,ind,res,nictoMULTI_PART_TLD_PREFIXES— these are India's registered ccSLD patterns (similar to.co.uk)14558535-f7ff-4abc-b0c3-12962ba5e0ec)Test plan
hdfc.bank.in→hdfc,icici.bank.in→iciciacme.firm.in→acme,iitd.res.in→iitd,example.nic.in→example🤖 Generated with Claude Code