feat(forms): use camelCase keys in messages to/from mystique (FORMS-20458)#2571
Open
05rahulsingh wants to merge 4 commits into
Open
feat(forms): use camelCase keys in messages to/from mystique (FORMS-20458)#257105rahulsingh wants to merge 4 commits into
05rahulsingh wants to merge 4 commits into
Conversation
…0458) Replace snake_case keys (form_source, cta_text, cta_source, form_details, form_navigation, page_views, form_views, cta_clicks) with camelCase equivalents in all SQS messages exchanged with mystique for consistent naming convention. Co-Authored-By: Rahul Kumar Singh <rahulksi@adobe.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
This PR will trigger a minor release when merged. |
…reFormByDetails Follow-up to the SQS message key rename — `shouldIgnoreFormByDetails` was still reading `form_type`/`is_lead_gen` (snake_case), which would always return false once mystique started sending camelCase. Updated source and all affected test stubs to use `formType`/`isLeadGen`/`formCategory`. Co-Authored-By: Rahul Kumar Singh <rahulksi@adobe.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
form_source,cta_text,cta_source,form_details,form_navigation,page_views,form_views,cta_clicks) with camelCase equivalents in SQS messages sent to mystique viasendMessageToFormsQualityAgentandsendMessageToMystiqueForGuidancedetect-form-details.jsto readformSourceandformDetailsfrom incoming mystique responsesformSourceinstead ofform_sourcefrom incoming mystique guidance messagesMotivation
Consistent camelCase convention for all SQS message keys across the audit-worker ↔ mystique boundary. Jira: FORMS-20458
Test plan
npm test)Co-authors
🤖 Generated with Claude Code