chore: clotton dev alias for isolated testing (SITES-47125)#2749
Draft
clotton wants to merge 4 commits into
Draft
chore: clotton dev alias for isolated testing (SITES-47125)#2749clotton wants to merge 4 commits into
clotton wants to merge 4 commits into
Conversation
…TES-47125) Bot-protected sites like ups.com block crawlers by resetting the connection (e.g. HTTP/2 ERR_HTTP2_STREAM_ERROR) rather than returning an HTTP status. Since #2476 (SITES-40919), any thrown fetch error in the GET fallback was reported as a broken link (status 0), so these valid-but-bot-blocked URLs became false-positive "Status 0 / Broken External Links" on the dashboard. Discriminate by error: only a DNS-resolution failure (ENOTFOUND — the domain does not exist) is a definitive broken link. All other network-level failures (connection reset, HTTP/2 stream errors, TLS, timeout) mean the host is reachable but did not return a usable response — indistinguishable from a valid page that blocks bots — so they are no longer reported. Preserves the SITES-40919 case (nonexistent domains / intranet hosts that fail DNS still surface as status 0); fixes the SITES-47125 false positives. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…format Address MysticatBot review on #2727: the message fallback `/ENOTFOUND/.test()` matched any error whose message merely contained the substring (e.g. a wrapper "Retry after ENOTFOUND was cached"), which could re-introduce the false positives this fix removes. Primary signal stays `err.code === 'ENOTFOUND'` (Node's DNS resolver always sets it). The message check is now a narrow fallback: it only fires when no code is present and matches the canonical `getaddrinfo ENOTFOUND` format. Added a regression test asserting a non-DNS error containing the substring is NOT flagged, and clarified the message-fallback test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
This PR will trigger a minor release when merged. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Base automatically changed from
fix/SITES-47125-bot-blocked-external-links
to
main
July 8, 2026 17:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev testing branch on top of #2727.
Changes
deploy-devto use theclottonLambda alias so the audit-worker can be tested in isolation via the developer isolated environments setup (https://wiki.corp.adobe.com/spaces/AEMSites/pages/3532639533).Do not merge — this branch exists only to trigger a dev deploy. Will be deleted after testing.