feat: LLMO-3959 changing schema to add detectCdn flag#1501
Merged
AddyKen-ghost merged 3 commits intomainfrom Apr 10, 2026
Merged
feat: LLMO-3959 changing schema to add detectCdn flag#1501AddyKen-ghost merged 3 commits intomainfrom
AddyKen-ghost merged 3 commits intomainfrom
Conversation
LLMO-3959 Made-with: Cursor
|
This PR will trigger a minor release when merged. |
…onfig.llmo
Remove the top-level detectedCdn column from the Site schema (avoids DB
migration) and nest it inside config.llmo where it is validated as
Joi.string().valid('aem-cs-fastly', 'other'). Add getter/setter helpers
on the Config model.
Made-with: Cursor
…DetectedCdn Follow existing getter/setter test pattern (CdnBucketConfig, CountryCodeIgnoreList) with four cases: get with data, default config, field absent, and update. Made-with: Cursor
akshaymagapu
approved these changes
Apr 10, 2026
solaris007
pushed a commit
that referenced
this pull request
Apr 10, 2026
## [@adobe/spacecat-shared-data-access-v3.50.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v3.49.0...@adobe/spacecat-shared-data-access-v3.50.0) (2026-04-10) ### Features * LLMO-3959 changing schema to add detectCdn flag ([#1501](#1501)) ([0bb4642](0bb4642))
Member
|
🎉 This PR is included in version @adobe/spacecat-shared-data-access-v3.50.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for persisting the auto-detected CDN provider inside
config.llmo.detectedCdnon the Site model, as part of the LLMO onboarding CDN auto-detection feature (LLMO-3959).Changes
detectedCdn: Joi.string().valid('aem-cs-fastly', 'other').optional()to thellmoconfig objectgetLlmoDetectedCdn()getter (returnsnullwhen absent) andupdateLlmoDetectedCdn()setterdetectedCdnattribute — the value is now nested inside the existingconfigJSONB column, avoiding a database migrationThree-state values
'aem-cs-fastly''other'null/ absent