Skip to content

Commit 58c6899

Browse files
incorporate review comments
1 parent c640c0a commit 58c6899

5 files changed

Lines changed: 4 additions & 10 deletions

File tree

.eslintrc.cjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2021 Adobe. All rights reserved.
2+
* Copyright 2025 Adobe. All rights reserved.
33
* This file is licensed to you under the Apache License, Version 2.0 (the "License");
44
* you may not use this file except in compliance with the License. You may obtain a copy
55
* of the License at http://www.apache.org/licenses/LICENSE-2.0

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Contributing to Project Franklin
1+
# Contributing to Sites Optimizer
22

33
This project (like almost all of Project Franklin) is an Open Development project and welcomes contributions from everyone who finds it useful or lacking.
44

src/tasks/demo-url-processor/handler.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,7 @@ export async function runDemoUrlProcessor(message, context) {
4242
try {
4343
// prepare demo url
4444
const demoUrl = prepareDemoUrl(siteUrl, organizationId, siteId);
45-
let slackMessage = ':white_check_mark: Setup complete!';
46-
await say(env, log, slackContext, slackMessage);
47-
slackMessage = `:information_source: Access your demo environment here: ${demoUrl}`;
45+
const slackMessage = `:white_check_mark: Setup complete! Access your demo environment here: ${demoUrl}`;
4846
await say(env, log, slackContext, slackMessage);
4947
log.info(`Setup complete! Access your demo environment here: ${demoUrl}`);
5048
} catch (error) {

src/tasks/disable-import-audit-processor/handler.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ export async function runDisableImportAuditProcessor(message, context) {
3636
importTypes,
3737
auditTypes,
3838
});
39-
await say(env, log, slackContext, ':broom: *Disabling imports and audits*');
4039
try {
4140
// Database operations
4241
log.info('Starting database operations');
@@ -62,9 +61,7 @@ export async function runDisableImportAuditProcessor(message, context) {
6261
await configuration.save();
6362
log.info('Database changes saved successfully');
6463

65-
let slackMessage = `:white_check_mark: Disabled imports ${JSON.stringify(importTypes)} for site ${siteId}`;
66-
await say(env, log, slackContext, slackMessage);
67-
slackMessage = `:white_check_mark: Disabled audits ${JSON.stringify(auditTypes)} for site ${siteId}`;
64+
const slackMessage = `:broom: *Disabled imports*: ${importTypes.join(', ')} and *audits*: ${auditTypes.join(', ')}`;
6865
await say(env, log, slackContext, slackMessage);
6966
} catch (error) {
7067
log.error('Error in disable import and audit processor:', {

src/tasks/opportunity-status-processor/handler.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ export async function runOpportunityStatusProcessor(message, context) {
6060
auditTypes,
6161
});
6262

63-
await say(env, log, slackContext, ':information_source: *Checking opportunity status*');
6463
try {
6564
// Get the site and its opportunities
6665
const site = await Site.findById(siteId);

0 commit comments

Comments
 (0)