use suggestions with in js file

Author: tkotthakota-adobe

src/tasks/cwv-demo-suggestions-processor/handler.js

@@ -11,9 +11,6 @@
  */
 
 import { isNonEmptyArray } from '@adobe/spacecat-shared-utils';
-import { readFileSync } from 'fs';
-import { join } from 'path';
-import { fileURLToPath } from 'url';
 import { say } from '../../utils/slack-utils.js';
 
 const TASK_TYPE = 'cwv-demo-suggestions-processor';
@@ -23,6 +20,25 @@ const INP = 'inp';
 const DEMO = 'demo';
 const MAX_CWV_DEMO_SUGGESTIONS = 2;
 
+// CWV reference suggestions defined as global variable to avoid file loading issues
+const cwvReferenceSuggestions = {
+  lcp: [
+    '## **Optimize Image Delivery:**\n• Use next-gen formats (WebP, AVIF)\n• Implement lazy loading\n• Compress images appropriately\n• Use responsive images with srcset\n• Consider image sprites for icons\n• Preload critical above-the-fold images',
+    '## **Optimize CSS Loading:**\n• Inline critical CSS\n• Defer non-critical CSS\n• Use media queries conditionally\n• Minify CSS files\n• Consider CSS-in-JS for dynamic styling\n• Implement CSS containment',
+    '## **Optimize Server & Network:**\n• Use CDN for global distribution\n• Enable GZIP/Brotli compression\n• Implement HTTP/2 or HTTP/3\n• Use edge caching strategies\n• Consider service workers\n• Use resource hints (preconnect, dns-prefetch)',
+  ],
+  cls: [
+    '## **Prevent Layout Shifts:**\n• Set explicit width/height on images/videos\n• Use aspect-ratio CSS property\n• Implement skeleton screens\n• Reserve space for dynamic content\n• Avoid inserting content above existing content\n• Use CSS Grid/Flexbox for predictable layouts',
+    '## **Optimize Animations:**\n• Use CSS transforms and opacity\n• Implement will-change property\n• Use transform3d for stacking context\n• Avoid changing layout properties during animations\n• Use requestAnimationFrame for smooth animations\n• Consider CSS transitions over JavaScript animations',
+    '## **Maintain Visual Stability:**\n• Implement skeleton screens\n• Reserve space for dynamic content\n• Use content-visibility CSS property\n• Implement CSS containment\n• Use CSS Grid and Flexbox\n• Avoid cumulative layout shifts',
+  ],
+  inp: [
+    '## **Break Up JavaScript Tasks:**\n• Use setTimeout or requestIdleCallback\n• Implement web workers for CPU-intensive operations\n• Use requestAnimationFrame for visual updates\n• Consider Intersection Observer API\n• Implement virtual scrolling for long lists\n• Use microtasks and macrotasks appropriately',
+    '## **Optimize Event Handling:**\n• Debounce input events\n• Use passive event listeners\n• Implement event delegation\n• Use AbortController to cancel operations\n• Consider ResizeObserver and MutationObserver\n• Optimize event listener registration',
+    '## **Optimize DOM Manipulation:**\n• Implement virtual scrolling\n• Use DocumentFragment for batch updates\n• Implement object pooling\n• Use Web Components for encapsulation\n• Implement progressive enhancement\n• Minimize DOM queries and mutations',
+  ],
+};
+
 /**
  * CWV thresholds for determining if metrics have issues
  */
@@ -68,10 +84,9 @@ function hasExistingIssues(suggestion) {
 /**
  * Gets a random suggestion from the available suggestions for a given issue type
  * @param {string} issueType - The type of issue (lcp, cls, inp)
- * @param {object} cwvReferenceSuggestions - The CWV reference suggestions object
  * @returns {string|null} A random suggestion or null if none available
  */
-function getRandomSuggestion(issueType, cwvReferenceSuggestions) {
+function getRandomSuggestion(issueType) {
   const suggestions = cwvReferenceSuggestions[issueType];
   if (!isNonEmptyArray(suggestions)) {
     return null;
@@ -94,25 +109,7 @@ async function updateSuggestionWithGenericIssues(
   suggestion,
   metricIssues,
   logger,
-  env,
-  slackContext,
 ) {
-  let cwvReferenceSuggestions = {};
-
-  try {
-    const filename = fileURLToPath(import.meta.url);
-    logger.info('Debug - filename:', filename);
-    const CWV_SUGGESTIONS_FILE_PATH = join(filename, 'aem-best-practices.json');
-    logger.info(`Loading CWV suggestions from: ${CWV_SUGGESTIONS_FILE_PATH}`);
-
-    const jsonContent = readFileSync(CWV_SUGGESTIONS_FILE_PATH, 'utf8');
-    cwvReferenceSuggestions = JSON.parse(jsonContent);
-    logger.info(`Successfully loaded CWV suggestions with keys: ${Object.keys(cwvReferenceSuggestions).join(', ')}`);
-  } catch (error) {
-    logger.warn(`Failed to load CWV reference suggestions: ${error.message}`);
-    await say(env, logger, slackContext, `Failed to load CWV reference suggestions: ${error.message}`);
-  }
-
   let issuesAdded = 0;
 
   try {
@@ -207,8 +204,6 @@ async function processCWVOpportunity(opportunity, logger, env, slackContext) {
         suggestion,
         metricIssues,
         logger,
-        env,
-        slackContext,
       );
       return issuesAdded;
     });